Bug 41909
| Summary: | libtool substitution in bsd.port.mk breaks with trailing slash | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Skye Poier <skye> |
| Component: | Individual Port(s) | Assignee: | Ade Lovett <ade> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-ports->portmgr to maintainer Pathnames specified in $path shouldn't really have trailing slashes, so the
pattern really isn't at fault.
However, to act defensively, we could do something like this:
LIBTOOLDIR=`${WHICH} ${LIBTOOL} | ${SED} -e
's^/bin/libtool^/share/libtool^ -e 's^//^/^'` || ${LOCALBASE}/share/libtool;
\
Responsible Changed From-To: portmgr->ade I'll be looking at all things libtool prior to 4.8-RELEASE The same problem exists on FreeBSD-5.0 (ports/50069). Note, that any number of trailing slash is absolutely legal as far as I remember POSIX. harti State Changed From-To: open->closed Superceded by 50069 |
If you set path = (/usr/local/bin/ $path) and try to install a port that depends on libtool, bsd.port.mk will fail during libtool path substitution: LIBTOOLDIR=`${WHICH} ${LIBTOOL} | ${SED} -e 's^/bin/libtool^/share/libtool^'` || +${LOCALBASE}/share/libtool; \ because 'which libtool' returns /usr/local/bin//libtool Fix: Pattern should be fixed in bsd.port.mk