Summary: | [patch] ISO-fication of /usr/src/contrib/tcp_wrappers | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | yuri | ||||||||||||
Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Only Me | CC: | osidorkin, pfg | ||||||||||||
Priority: | Normal | Flags: | pfg:
mfc-stable10+
pfg: mfc-stable9+ bugmeister: mfc-stable8? |
||||||||||||
Version: | 4.6-STABLE | ||||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=42327 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=32808 |
||||||||||||||
Attachments: |
|
Description
yuri
2002-09-02 21:10:01 UTC
BTW: The updated copyright by the author allows to modify the code ;) ftp://ftp.porcupine.org/pub/security/tcp_wrappers_license State Changed From-To: open->closed dup with pr/43227 State Changed From-To: closed->open oops... my fat fingers Created attachment 148193 [details]
Updated patch
The first two patches were bogus (no apparent change), and I don't find it much use in dropping the __STDC__ . I did take the chance to cleanup somewhat the spacing issues. This is pending testing.
Created attachment 148196 [details]
Updated patch
A commit references this bug: Author: pfg Date: Sat Oct 11 18:34:11 UTC 2014 New revision: 272949 URL: https://svnweb.freebsd.org/changeset/base/272949 Log: tcpd: complete function prototypes. This clears up at least a build issues on mysql-server ports. While here also replace some spaces with tabs in our headers. PR: 42336 MFC after: 2 weeks Changes: head/contrib/tcp_wrappers/inetcf.h head/contrib/tcp_wrappers/mystdarg.h head/contrib/tcp_wrappers/tcpd.h head/contrib/tcp_wrappers/tli-sequent.h Is this patch going to be actually MFC'ed? (In reply to osidorkin from comment #7) I was planning to MFC it only to 10-stable. Is there a use case for it? (In reply to Pedro F. Giffuni from comment #8) I'm experimenting with mysql-5.7 development release and it uses tcpwrappers inside c++ code. However I don't know any issues with existing ports. (In reply to osidorkin from comment #9) The port has local patches to work around the issues. I will MFC the patch soon to 10-stable and 9-stable. A commit references this bug: Author: pfg Date: Sat Jan 17 01:20:29 UTC 2015 New revision: 277281 URL: https://svnweb.freebsd.org/changeset/base/277281 Log: MFC r272947, r272950: tcpd: complete function prototypes. tcpd.h: add prototype for hosts_ctl This clears up at least a build issues on mysql-server ports. While here also replace some spaces with tabs in our headers. PR: 32808 PR: 42336 Changes: _U stable/10/ stable/10/contrib/tcp_wrappers/inetcf.h stable/10/contrib/tcp_wrappers/mystdarg.h stable/10/contrib/tcp_wrappers/tcpd.h stable/10/contrib/tcp_wrappers/tli-sequent.h A commit references this bug: Author: pfg Date: Sat Jan 17 01:21:32 UTC 2015 New revision: 277282 URL: https://svnweb.freebsd.org/changeset/base/277282 Log: MFC r272947, r272950: tcpd: complete function prototypes. tcpd.h: add prototype for hosts_ctl This clears up at least a build issues on mysql-server ports. While here also replace some spaces with tabs in our headers. PR: 32808 PR: 42336 Changes: stable/9/contrib/tcp_wrappers/inetcf.h stable/9/contrib/tcp_wrappers/mystdarg.h stable/9/contrib/tcp_wrappers/tcpd.h stable/9/contrib/tcp_wrappers/tli-sequent.h A commit references this bug: Author: dim Date: Mon Jan 9 20:14:21 UTC 2017 New revision: 311816 URL: https://svnweb.freebsd.org/changeset/base/311816 Log: MFC r257398 (by sbruno): Quiesce warnings by updating headerfile includes r257404 | sbruno | 2013-10-30 23:41:18 +0100 (Wed, 30 Oct 2013) | 9 lines Quiesce two warnings: 1. define the CODE * as const 2. restructure function to eliminate warning about exiting with no return. severity_map() never returns when it can't find an appropriate sysylog facility, and it longjmp()'s away into error code handling. Keep this behavior by stashing the facility value found during our search and checking for -1 if found. MFC r257405 (by sbruno): Quiesce warning, which could be a bug IMO, by correctly defining the host_info structure name MFC r257406 (by sbruno): Queisce warning about undeclared function usage. yp_get_default_domain is defined in workaround.c but is not declared in any header file. Tie the declaration to the same #define conditional used when the function is called, NETGROUP MFC r272949 (by pfg): tcpd: complete function prototypes. This clears up at least a build issues on mysql-server ports. While here also replace some spaces with tabs in our headers. PR: 42336 MFC r272950 (by pfg): tcpd.h: add prototype for hosts_ctl According the hosts_access(3) man page the hosts_ctl() prototype should be in tcpd.h. For now, follow other declarations and don't add the arguments in the prototype. Reference: https://www.illumos.org/issues/4385 PR: 32808 MFC r311459: Put proper prototypes in tcpd.h Clang 4.0.0 complains about tcpd.h's not-really-prototypes, e.g.: /usr/include/tcpd.h:75:24: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] extern int hosts_access(); /* access control */ ^ To fix this, turn these declarations into real prototypes. While here, garbage collect the incompatible rfc931() function from scaffold.c, as it is never used. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D9052 MFC r311461: Also remove unnecessary extern keywords from tcpd.h. Noticed by: kib MFC r311556: After r311459, some ports can break, because a few of the newly added prototypes in <tcpd.h> use FILE. Pull in a minimal forward declaration of FILE from <stdio.h> to minimize impact. Sorry for the breakage. Reported by: Shawn Webb <shawn.webb@hardenedbsd.org> Changes: _U stable/9/ _U stable/9/contrib/ stable/9/contrib/tcp_wrappers/clean_exit.c stable/9/contrib/tcp_wrappers/hosts_access.c stable/9/contrib/tcp_wrappers/options.c stable/9/contrib/tcp_wrappers/percent_x.c stable/9/contrib/tcp_wrappers/rfc931.c stable/9/contrib/tcp_wrappers/scaffold.c stable/9/contrib/tcp_wrappers/shell_cmd.c stable/9/contrib/tcp_wrappers/tcpd.h stable/9/contrib/tcp_wrappers/update.c |