Bug 42545

Summary: x11-wm/fvwm2: make package fails.
Product: Ports & Packages Reporter: Udo.Schweigert
Component: Individual Port(s)Assignee: Cy Schubert <cy>
Status: Closed FIXED    
Severity: Affects Only Me CC: cy
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Udo.Schweigert 2002-09-08 10:20:01 UTC
"make package" fails if not used in a GNOME environment (but even with GNOME
I think the package won't be built because share/gnome/fvwm isn't filled).

Here's what I got:

===>  Building package for fvwm-imlib-2.4.9
Creating package /usr/ports/packages/All/fvwm-imlib-2.4.9.tbz
Registering depends: XFree86-libraries-4.2.1 freetype2-2.1.2 imake-4.2.0_1 m4-1.4_1.
Creating bzip'd tar ball in '/usr/ports/packages/All/fvwm-imlib-2.4.9.tbz'
tar: share/gnome/fvwm/ConfigFvwmBacker: Cannot stat: No such file or directory
tar: share/gnome/fvwm/ConfigFvwmButtons: Cannot stat: No such file or directory

....

Fix: The variable HAVE_GNOME is always defined. The correct way to check for GNOME
(as stated in /usr/ports/Mk/bsd.gnomeng.mk) is like in this patch:



This also leaves the packages name without the -imlib suffix.--lTK8CliBRMmRUPr11067cmtaBJfcQ3THr1wsNRRzc8zzgDtq
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	Mon Sep  2 06:06:59 2002
+++ Makefile	Sun Sep  8 11:03:18 2002
@@ -52,7 +52,7 @@
 
 PLIST_SUB+=	FVWM_VERSION="${PORTVERSION}"
 
-.if defined(HAVE_GNOME)
+.if ${HAVE_GNOME:Mimlib}!=""
 USE_GNOME=	yes
 PLIST_SUB+=	GNOMEDATADIR="share/gnome/fvwm"
 .else
How-To-Repeat: 
make -DWITHOUT_GNOME package
Comment 1 Oliver Braun freebsd_committer freebsd_triage 2002-09-08 10:23:11 UTC
Responsible Changed
From-To: freebsd-ports->cy

Over to maintainer(s)
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2002-09-09 02:16:40 UTC
State Changed
From-To: open->closed

Fixed. Thanks for telling us. 
Cause: GNOMENG