Bug 42565

Summary: Unbreak games/xpuyopuyo after GNOMENG mass commit
Product: Ports & Packages Reporter: Tilman Linneweh <tilman>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me CC: lioux
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
xpuyopuyo.diff none

Description Tilman Linneweh 2002-09-08 23:40:06 UTC 
	This port needs GTK even if build WITHOUT_GNOME,
	If build with GNOME, it looks for gnome-config -> it needs gnomelibs
	DATADIR PLIST_SUB isn't defined in bsd.gnomeng.mk anymore.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-08 23:41:48 UTC 
Responsible Changed
From-To: freebsd-ports->marcus

I'll take this.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-08 23:46:39 UTC 
Wouldn't you rather conditionalize the PLIST_SUB on whether or not GNOME
is available?  For example:

.if ${HAVE_GNOME:Mgnomelibs}!=""
USE_GNOME+=	gnomehack gnomelibs
PKGNAMESUFFIX=	-gnome
PLIST_SUB+=	DATADIR="share/gnome"
.else
PLIST_SUB+=	DATADIR="share"
.endif

Joe
-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	marcus@FreeBSD.org
http://www.FreeBSD.org/gnome
Comment 3 Tilman Linneweh 2002-09-09 00:10:08 UTC 
Hi,

* Joe Marcus Clarke <marcus@FreeBSD.org> [08 Sep 2002 18:46:39 -0400]:

> Wouldn't you rather conditionalize the PLIST_SUB on whether or not GNOME
> is available?  For example:

Yeah, thats the way the old port behaved. 

> .if ${HAVE_GNOME:Mgnomelibs}!=""
> USE_GNOME+=	gnomehack gnomelibs
> PKGNAMESUFFIX=	-gnome
> PLIST_SUB+=	DATADIR="share/gnome"
> .else
> PLIST_SUB+=	DATADIR="share"
> .endif

Thanks && regards
arved
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2002-09-09 02:27:45 UTC 
State Changed
From-To: open->closed

Committed, thanks.