Bug 43772

Summary: xrolo port fails to build
Product: Ports & Packages Reporter: Charles Allen <charles.allen>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Charles Allen 2002-10-07 17:10:01 UTC 
	The xrolo port fails to build, complaining about previous
	declarations of calloc and malloc.  Here is the result:

===>   Returning to build of xrolo-2.6
===>   xrolo-2.6 depends on shared library: X11.6 - found
===>  Patching for xrolo-2.6
===>  Applying FreeBSD patches for xrolo-2.6
===>  Configuring for xrolo-2.6
mv -f Makefile Makefile.bak
imake -DUseInstalled -I/usr/X11R6/lib/X11/config
make Makefiles
make includes
make depend
rm -f .depend
gccmakedep -f-  -- -I$OPENWINHOME/include  -I/usr/X11R6/include    -DCSRG_BASED 
 -DFUNCPROTO=15 -DNARROWPROTO   -DSTANDALONE -DMAILER=\"/usr/bin/mail\" -DVERSIO
N=\"2.0\"               -DDONT_USE_MALLOC_LIST  -DUSE_MAKEDEPEND -- main.c panel
.c cards.c popup.c send_mail.c soundex.c phone.c > .depend
===>  Building for xrolo-2.6
cc -O -pipe       -I$OPENWINHOME/include  -I/usr/X11R6/include    -DCSRG_BASED  
-DFUNCPROTO=15 -DNARROWPROTO   -DSTANDALONE -DMAILER=\"/usr/bin/mail\" -DVERSION
=\"2.0\"                -DDONT_USE_MALLOC_LIST  -c main.c
main.c:69: conflicting types for `calloc'
/usr/include/stdlib.h:94: previous declaration of `calloc'
main.c:69: conflicting types for `malloc'
/usr/include/stdlib.h:101: previous declaration of `malloc'
*** Error code 1

Stop in /usr/ports/deskutils/xrolo/work/xrolo.
*** Error code 1

Stop in /usr/ports/deskutils/xrolo.

How-To-Repeat: 	Go to /usr/ports/deskutils/xrolo and type "make install clean"
A
	as root.
Comment 1 Adam Weinberger 2002-10-07 19:07:16 UTC 
fix is this patch, which patches ${FILESDIR}/patch-ab.


--- patch-ab.orig	Sun Jan 17 20:16:21 1999
+++ patch-ab	Mon Oct  7 10:43:50 2002
@@ -17,6 +17,25 @@
   #include <xview/xview.h>
   #include <xview/panel.h>
   #include <xview/textsw.h>
+***************
+*** 65,72 ****
+  
+  extern void		init_rolo ();
+  
+! extern char		*check_args (), *getenv (), *strcpy (),
+! 			*calloc (), *malloc ();
+  
+  extern char             *exp_fname();
+  
+--- 65,72 ----
+  
+  extern void		init_rolo ();
+  
+! extern char		*check_args (), *getenv (), *strcpy ();/*,
+! 			*calloc (), *malloc ();*/
+  
+  extern char             *exp_fname();
+  
 ***************
 *** 320,323 ****
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2002-10-19 23:09:17 UTC 
Responsible Changed
From-To: freebsd-ports->adamw

I'll take care of this problem.
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2002-10-21 11:59:22 UTC 
State Changed
From-To: open->feedback

Waiting for approval from maintainer.
Comment 4 lkoeller freebsd_committer freebsd_triage 2002-11-03 21:47:48 UTC 
State Changed
From-To: feedback->closed

o Necessary patches are applied and correct build verified.