Bug 45213
| Summary: | [PATCH] Fix sorting in Additional Contributors sections (part 1 of 3) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Documentation | Reporter: | Sergei Kolobov <sergei> | ||||
| Component: | Books & Articles | Assignee: | Christian Brueffer <brueffer> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Sergei Kolobov
2002-11-11 15:00:08 UTC
Responsible Changed From-To: gnats-admin->freebsd-doc Over to freebsd-doc On 2002-11-11 14:52, Sergei Kolobov <sergei@kolobov.com> wrote: > List of Additional Contributors is supposed to be sorted by first > name. Unfortunately, the sort order is broken in a few places. > This first of three patches to fix the sort order. > > Patch 1 fixes line wrapping only: > - wrap lines exceeding 80 columns > - unwrap lines that could fit in 80 columns Hum. It's very difficult to find the unsorted entries in the submitted patch. I'd happily commit any change that fixes the sort order, but please don't mix whitespace changes (i.e. wrapping) with content changes. Giorgos,
On 2002-11-24 at 18:49 +0200, Giorgos Keramidas wrote:
> On 2002-11-11 14:52, Sergei Kolobov <sergei@kolobov.com> wrote:
> > List of Additional Contributors is supposed to be sorted by first
> > name. Unfortunately, the sort order is broken in a few places.
>
> > This first of three patches to fix the sort order.
> >
> > Patch 1 fixes line wrapping only:
> > - wrap lines exceeding 80 columns
> > - unwrap lines that could fit in 80 columns
>
> Hum. It's very difficult to find the unsorted entries in the
> submitted patch. I'd happily commit any change that fixes the sort
> order, but please don't mix whitespace changes (i.e. wrapping) with
> content changes.
That is exactly why I have splitted the patch into 3 PRs (please note
"part 1 of 3" in the synopsis field).
docs/45213: whitespace only - wrapping/unwrapping
docs/45214: content #1 - swapping last name/first name where needed
docs/45215: content #2 - re-sort
Hope this helps ;-)
Sergei
On 2002-11-25 14:02, Sergei Kolobov <sergei@kolobov.com> wrote: > > Hum. It's very difficult to find the unsorted entries in the > > submitted patch. I'd happily commit any change that fixes the > > sort order, but please don't mix whitespace changes (i.e. > > wrapping) with content changes. > > That is exactly why I have splitted the patch into 3 PRs (please note > "part 1 of 3" in the synopsis field). > > docs/45213: whitespace only - wrapping/unwrapping > docs/45214: content #1 - swapping last name/first name where needed > docs/45215: content #2 - re-sort Ah, pardon me. I do apologise. I didn't notice it was split in 3 different PRs, and thought that somehow you had submitted a single patch for all 3 changes! It looks good, but I don't think we can fit all the SGML sources in less than 80 columns so I'm not sure the first patch is a definite must... On 2002-11-25 at 18:54 +0200, Giorgos Keramidas wrote: > Ah, pardon me. I do apologise. I didn't notice it was split in 3 > different PRs, and thought that somehow you had submitted a single > patch for all 3 changes! No problem. > It looks good, but I don't think we can fit > all the SGML sources in less than 80 columns so I'm not sure the first > patch is a definite must... I was just trying to make it consistent throughout the article - most of the items that exceeded 80 columns were wrapped, so I added wrapping for few items that weren't, and unwrapped those that could be fit in 80 columns. Responsible Changed From-To: freebsd-doc->brueffer I will work on this State Changed From-To: open->closed I've converted all entries to the format which was only used by entries that were too long. Thanks for the patch which inspired this change! |
