Bug 46709

Summary: [patch] tables in terminfo(5) are broken
Product: Documentation Reporter: Kazuo Horikawa <horikawa>
Component: Books & ArticlesAssignee: ru <ru>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Kazuo Horikawa freebsd_committer freebsd_triage 2003-01-03 04:50:00 UTC
	Formatted terminfo.5 page shows corrupt tables like:

	       Variable 	    Cap-    TCap      Description
	       Booleans 	    name    Code
       auto_left_margin 		    bw	      bw
       T}
       auto_right_margin		    am	      am
       T}

	src/contrib/ncurses/man/MKterminfo.sh produced the corrupt
	tables. (Is this due to difference between GNU sed and
	FreeBSD sed?)

	terminfo.5 is a part of src/contrib/ncurses.

Fix: src/contrib/ncurses/MKterminfo.sh with following change
	produces correct tables in resulting roff file.
How-To-Repeat: 
	man 5 terminfo
Comment 1 Kazuo Horikawa freebsd_committer freebsd_triage 2003-01-08 07:31:55 UTC
I got valuable feedback from Thomas Dickey <dickey@herndon4.his.com>,
who is the owner of ftp://dickey.his.com/ncurses/ where FreeBSD
obtained the ncurses sources from.

I confirmed that suggested modification works on FreeBSD (following is
diff to original MKterminfo.sh).

--- MKterminfo.sh.bak	Thu Jan  2 20:22:55 2003
+++ MKterminfo.sh	Wed Jan  8 00:24:12 2003
@@ -68,9 +68,9 @@
 /%%-STOP-HERE-%%/q
 /^#%/s///p
 /^#/d
-s/[	]\+/	/g
+s/[	][	]*/	/g
 s/$/T}/
-s/	[A-Z0-9_()\-]\+	[0-9\-]\+	[Y\-][B\-][C\-][G\-][EK\-]\**	/	T{/
+s/	[A-Z0-9_()\-][A-Z0-9_()\-]*	[0-9\-][0-9\-]*	[Y\-][B\-][C\-][G\-][EK\-]\**	/	T{/
 s/	bool	/	/p
 s/	num	/	/p
 s/	str	/	/p

-- Kazuo Horikawa

On Mon, Jan 06, 2003 at 08:04:53PM -0700, Kazuo Horikawa wrote:
> "Thomas E. Dickey" <dickey@herndon4.his.com> wrote:
> > On Sun, 5 Jan 2003, Kazuo Horikawa wrote:
> > 
> > > (cc'ing peter, as he imported ncurses-5.2-20020518 to FreeBSD 7 monthes ago)
> > >
> > > Hi,
> > >
> > > Do you mind if FreeBSD will have the modification (e.g., my proposed
> > > diff to MKterminfo.sh) locally?
> > 
> > I suppose it won't hurt.  Which version of sed is that?  I had thought
> > FreeBSD was using GNU sed, because of the previous conversation regarding
> > the POSIXLY_CORRECT feature (which changes the behavior of GNU sed to
> > make it incompatible with most other versions of sed).
> 
> It seems for me the sed is not GNU.

I see a better fix - had forgotten that the '+' mark is not considered part
of the "basic" regular expressions for which sed is standardized.  (I recall
having some problems with lynx over this).  I'll replace those with a
different expression, e.g.,
	[0-9]+
by
	[0-9][0-9]*

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
Comment 2 Jens Schweikhardt freebsd_committer freebsd_triage 2004-07-24 12:57:19 UTC
State Changed
From-To: open->analyzed

This is a duplicate of 56981 and the fix is the same: 
Update contrib/ncurses to 5.4. 


Comment 3 Jens Schweikhardt freebsd_committer freebsd_triage 2004-07-24 12:57:19 UTC
Responsible Changed
From-To: freebsd-doc->peter

Peter, if you import ncurses 5.4, this PR can be closed as well.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-10-14 20:51:07 UTC
ru          2006-10-14 19:50:57 UTC

  FreeBSD src repository

  Modified files:        (Branch: NCURSES)
    contrib/ncurses/man  MKterminfo.sh 
  Log:
  Fix from upstream: unbreak generation of the terminfo.5 manpage.
  
  PR:             docs/46709, docs/56981, docs/80871
  MFC after:      3 days
  Obtained from:  ftp://invisible-island.net/ncurses/ncurses-5.5.tar.gz
  
  Revision  Changes    Path
  1.1.1.4   +15 -12    src/contrib/ncurses/man/MKterminfo.sh
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 ru freebsd_committer freebsd_triage 2006-10-14 20:52:14 UTC
State Changed
From-To: analyzed->closed

I've committed a vendor fix on the vendor branch. 


Comment 6 ru freebsd_committer freebsd_triage 2006-10-14 20:52:14 UTC
Responsible Changed
From-To: peter->ru