Bug 46863

Summary: tin newsreader improperly deals with charsets
Product: Ports & Packages Reporter: Seva Gluschenko <gvs>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Seva Gluschenko 2003-01-08 12:40:01 UTC
	When using tin newsreader from ports collection for reading national
	newsgroups you're finishing soon with messages full of question marks
	because tin was configured for strict MM_CHARSET obeyance.

Fix: Just add --disable-mime-strict-charset to configure options, as follows:



It might be preferable also to change

	--with-mime-default-charset=US-ASCII

	to smth like

	--with-mime-default-charset=${MM_CHARSET:-US-ASCII},

	but the only --disable-mime-strict-charset switch has a principal
	meaning.

	Worth of mentioning, tin has now --with-x and --with-Xaw3d configure
	options which might be added to the user selectable conditional
	includes (consider it the wish list).

	Finally, it's better to display the message like libxml2 port does, to
	let the user choose the desirable options for building tin.

	That's all, thank you in advance.--UIOkegruK6GbaPtdswAPawwVaPFl4x6uq6td5b9qBrdStEfA
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig       Wed Jan  8 15:25:11 2003
+++ Makefile    Wed Jan  8 15:25:27 2003
@@ -32,6 +32,7 @@
                --with-screen=ncurses \
                --enable-break-long-lines \
                --with-libiconv-prefix=${LOCALBASE} \
+               --disable-mime-strict-charset \
                --with-mime-default-charset=US-ASCII
 CONFIGURE_ENV=  CFLAGS='${CFLAGS} -DNNTP_SERVER_FILE="\"${PREFIX}/etc/nntpserver\""' \
                CPPFLAGS='${CPPFLAGS} -I${LOCALBASE}/include' \
How-To-Repeat: 	Just update ports collection, then cd to news/tin and type

	make all install

	After tin package is built and installed. run it and watch results.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2003-01-08 12:45:33 UTC
Responsible Changed
From-To: freebsd-ports->ache

Over to Maintainer
Comment 2 Andrey A. Chernov freebsd_committer freebsd_triage 2003-01-08 16:11:58 UTC
State Changed
From-To: open->closed

Read docs about undeclared_charset option