Bug 48494

Summary:	BP6 ACPI errors - AML incorrect
Product:	Base System	Reporter:	Christopher Dutchyn <cdutchyn>
Component:	kern	Assignee:	njl
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	5.0-CURRENT
Hardware:	Any
OS:	Any

Description Christopher Dutchyn 2003-02-20 20:00:07 UTC

boot FreeBSD 5.0-RELEASE or -CURRENT on BP6 with RU revision
BIOS

Fix: 

The problem seems to be an incorrect entry in the BP6 AML.  In particular,
the system
	inventory shows two processors in scope \_PR, called \_PR.CPU_ and
\_PR.CPU1.  But in
	scope \_TZ_, ThermalZone THRM, Name _PSL, Package 0x1, there is a reference
to \_PR.CPU0.

	I don't currently have the time nor tools to attempt to load a modified
AML.  But perhaps
	someone can confirm that this is suspect and then I'll actually try it.


Chris Dutchyn
cdutchyn@cs.ubc.ca
How-To-Repeat: 	look at dmesg output

Comment 1 Giorgos Keramidas freebsd_committer

2003-02-24 21:18:57 UTC

Responsible Changed
From-To: gnats-admin->freebsd-bugs

Misfiled PR.

Comment 2 Kris Kennaway freebsd_committer

2003-07-14 06:58:00 UTC

State Changed
From-To: open->feedback

Can you please retry with 5.1-RELEASE or 5.1-CURRENT?

Comment 3 Kris Kennaway freebsd_committer

2003-07-14 09:29:23 UTC

Responsible Changed
From-To: freebsd-bugs->acpi-jp@jp.FreeBSD.org

Assign to ACPI maintainers

Comment 4 Pawel Worach 2003-07-14 16:04:29 UTC

Here is a patch for the AML. This gets rid of all ACPI warnings
on my BP6.

--- abit.dsl.org        Mon Jul 14 06:20:41 2003
+++ abit.dsl    Mon Jul 14 06:24:26 2003
@@ -306,7 +306,7 @@
      {
          Method (_MSG, 1, NotSerialized)
          {
-            Store (Local0, Local0)
+            /* Store (Local0, Local0) */
          }

          Method (_SST, 1, NotSerialized)
@@ -329,7 +329,7 @@
              If (LEqual (Arg0, 0x03)) {}
              If (LEqual (Arg0, 0x01)) {}
              If (LEqual (Arg0, 0x00)) {}
-            Store (Local0, Local0)
+            /* Store (Local0, Local0) */
          }
      }

@@ -465,7 +465,7 @@

              Name (_PSL, Package (0x01)
              {
-                \_PR.CPU0
+                \_PR.CPU
              })
              Name (_TSP, 0x3C)
              Name (_TC1, 0x04)
@@ -1636,7 +1636,7 @@
                              IRQNoFlags () {6}
                              DMA (Compatibility, NotBusMaster, Transfer8) {2}
                          })
-                        Store (Local0, Local0)
+                        /* Store (Local0, Local0) */
                          Return (BUF0)
                      }

@@ -2023,7 +2023,7 @@
                              EXF1 ()
                          }

-                        Store (Local0, Local0)
+                        /* Store (Local0, Local0) */
                      }

                      Method (_CRS, 0, NotSerialized)

howto:
# acpidump -o abit.dsdt > abit.asl
# iasl -d abit.dsdt
# patch < abit.dsl.patch
# isal abit.dsl

Comment 5 Nate Lawson 2003-08-08 17:45:11 UTC

Thanks for the help Pawel.  I am working on making Store(Local0, Local0)
be a NOP so it would work even with the original AML.

-Nate

Comment 6 njl freebsd_committer

2003-08-08 17:45:15 UTC

Responsible Changed
From-To: acpi-jp@jp.FreeBSD.org->njl

I'm working on this.

Comment 7 Kris Kennaway 2003-08-16 04:36:11 UTC

Adding to audit trail

----- Forwarded message from Christopher Dutchyn <cdutchyn@cs.ubc.ca> -----

X-Original-To: kkenn@localhost
Delivered-To: kkenn@localhost.obsecurity.org
Delivered-To: kris@freebsd.org
Date: Tue, 22 Jul 2003 18:03:12 -0700 (PDT)
From: Christopher Dutchyn <cdutchyn@cs.ubc.ca>
To: Kris Kennaway <kris@freebsd.org>
Cc: freebsd-bugs@freebsd.org, pawel.worach@telia.com
Subject: Re: kern/48494: BP6 ACPI errors - AML incorrect
In-Reply-To: <200307140558.h6E5wFbf060314@freefall.freebsd.org>
X-UIDL: 1ab79120f3ca85fffb689f34f1b9e924
X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.13.7.2


The BP6 ACPI update works.  I had to install the acpitools port, and add
the dsdt load into my /boot/loader.conf to make it work.

Chris Dutchyn


----- End forwarded message -----

Comment 8 Nate Lawson 2003-11-25 00:31:16 UTC

Could you please tell me if you have this problem if you disable the dsdt
load in loader.conf?  It may have been fixed.  If not, it will be after an
import of ACPI-CA (after 5.2R).

-Nate

Comment 9 njl freebsd_committer

2003-12-14 20:24:48 UTC

State Changed
From-To: feedback->closed

The import of 1203 has fixed the Store(Local0, Local0) problem so your 
floppy will work even without editing the AML.  However, you may still 
have to change the CPU_ line.