Summary: | Update for port devel/cppunit | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | lev <lev> | ||||
Component: | Individual Port(s) | Assignee: | Lev A. Serebryakov <lev> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
lev
2003-02-24 16:00:27 UTC
Responsible Changed From-To: freebsd-ports-bugs->kde Anyone, please review it. * Norikatsu Shigemura [Fr, 11 Apr 2003 at 18:58 GMT]:
> Synopsis: Update for port devel/cppunit
>
> Responsible-Changed-From-To: freebsd-ports-bugs->kde
> Responsible-Changed-By: nork
> Responsible-Changed-When: Fri Apr 11 09:57:32 PDT 2003
> Responsible-Changed-Why:
> Anyone, please review it.
Why did you assign this PR to kde ? If I am not completly wrong this port has
nothing to do with KDE. There is a maintainer listed, that should review this.
Small review, without testing it: If WITH_DOXYGEN and NOPORTDOCS are
defined, there is a BUILD_DEPENDENCY on doxygen, but the doxygen docs aren't
generated. Suboptimal, but not really a problem, since this combination of
knobs does not make sense.
regards
tilman
On Fri, 11 Apr 2003 23:51:18 +0200 Tilman Linneweh <tilman+2003-04-11@arved.de> wrote: > > Responsible-Changed-From-To: freebsd-ports-bugs->kde > > Responsible-Changed-By: nork > Why did you assign this PR to kde ? If I am not completly wrong this port has > nothing to do with KDE. There is a maintainer listed, that should review this. > Small review, without testing it: If WITH_DOXYGEN and NOPORTDOCS are > defined, there is a BUILD_DEPENDENCY on doxygen, but the doxygen docs aren't > generated. Suboptimal, but not really a problem, since this combination of > knobs does not make sense. Oops, I missed. I saw devel/doxygen which devel/cppunit (new) is depended on. Sorry, I'll change responsible. Responsible Changed From-To: kde->freebsd-ports-bugs I missed direction. What does the maintainer think of this update? http://www.freebsd.org/cgi/query-pr.cgi?pr=48637 regards, -- wca On Wed, 11 Jun 2003 21:50:53 -0700, "Will Andrews" <will@csociety.org> said: > What does the maintainer think of this update? > http://www.freebsd.org/cgi/query-pr.cgi?pr=48637 > > regards, > -- > wca > From the testing I've done, Lev's patch looks good. Can you submit it? The only change I would make is to change my email address to <gcross@fastmail.fm>. Thanks Graeme -- Graeme Cross <gcross@netspace.net.au> Responsible Changed From-To: freebsd-ports-bugs->lev Submitter is now a committer and can handle his PRs on his own. Welcome! State Changed From-To: open->closed Commited, thanks. |