Bug 48960

Summary: An alternative solution for perllocal.pod files
Product: Ports & Packages Reporter: Anton Berezin <tobez>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Anton Berezin freebsd_committer freebsd_triage 2003-03-05 23:00:27 UTC 
Quoting a mail from ports@:

On Thu, Feb 20, 2003 at 06:22:38PM -0800, Kris Kennaway wrote:
> On Fri, Feb 21, 2003 at 08:44:08AM +0900, Jun Kuriyama wrote:
> > 
> > For Kris. :-)
> > 
> > I don't know which option is better.
> > 
> > (1) Add knob like below.
> >   pros: will not do (bad) effect other PERL_CONFIGURE ports unless
> >         knob is set.
> >   cons: requires to add knobs to all ports which has perllocal.pod.
> > 
> > (2) Add reinplace inside of .if defined(PERL_CONFIGURE) and doing this
> >     implicitly if $PERL_CONFIGURE is defined.
> >   pros: does not need to touch Makefile of each ports.  Only plist fix
> >         is required.
> >   cons: may cause some problems (I don't think so, but I don't know
> >         there is a program which uses perllocal.pod file).

It is supposed to be used for de-installation, but currently there is no
deinstall target anywhere.  Besides, the ports collection handles
de-installation mostly fine.  So it can be safely removed.

Another IMO important cons is the multitude of perllocal.pod-* files in
${PREFIX}/lib, which is undesirable.

> Thanks very much!  I'll test (2) on bento as soon as I can.

I would suggest the complete removal instead:
Comment 1 Anton Berezin freebsd_committer freebsd_triage 2003-03-05 23:00:45 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

A bsd.port.mk issue.
Comment 2 Erwin Lansing 2003-03-28 08:23:44 UTC 
This doesn't seem to take care of all cases. E.g. see
mail/p5-Mail-Procmailrc. I therefore propose the following patch
instead:


Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.444
diff -u -r1.444 bsd.port.mk
--- bsd.port.mk	22 Mar 2003 04:45:24 -0000	1.444
+++ bsd.port.mk	28 Mar 2003 08:20:58 -0000
@@ -2722,7 +2722,7 @@
 		${SETENV} ${CONFIGURE_ENV} \
 		${PERL5} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS}
 	@cd ${CONFIGURE_WRKSRC} && \
-		${REINPLACE_CMD} -e 's/perllocal.pod/&-${PORTNAME}/' Makefile
+		${PERL5} -pi -e 's/ doc_(perl|site|\$$\(INSTALLDIRS\))_install$$//' Makefile
 .endif
 .if defined(USE_IMAKE)
 	@(cd ${CONFIGURE_WRKSRC}; ${SETENV} ${MAKE_ENV} ${XMKMF})

-- 
                    _._     _,-'""`-._
Erwin Lansing      (,-.`._,'(       |\`-/|    http://droso.org/
erwin@lansing.dk       `-.-' \ )-`( , o o)    http://fnidder.dk/
                    -bf-      `-    \`_`"'-
Comment 3 Anton Berezin freebsd_committer freebsd_triage 2003-04-02 12:48:17 UTC 
I agree that Erwin's patch is better and should be used instead of mine.

Cheers,
\Anton.
-- 
It's a short step from "rigor" to "rigor mortis". -- Chip Salzenberg
Comment 4 Kris Kennaway freebsd_committer freebsd_triage 2003-04-13 04:55:30 UTC 
State Changed
From-To: open->analyzed

Currently being tested on bento
Comment 5 Kris Kennaway freebsd_committer freebsd_triage 2003-04-17 11:29:54 UTC 
State Changed
From-To: analyzed->closed

Patch committed, thanks!