Bug 49056

Summary: Festival fixes for newer GCCs [PATCH]
Product: Ports & Packages Reporter: Joel Ray Holveck <joelh>
Component: Individual Port(s)Assignee: Trevor Johnson <trevor>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
file.diff
none
file.diff none

Description Joel Ray Holveck 2003-03-09 21:20:13 UTC 
The version of Festival will not compile using GCC 3.2.1, apparently
primarily due to some changes in the C++ strictness.  Attached is a
patch to make it work.  (Technically, the patch applies to
speech_tools and OGI, not Festival proper, but they're all part of the
Festival port.)

All but one of these changes are in the current version of Festival,
but making a new port of that may be a bit of work, since the
configuration mechanism has changed.  This PR is here as a stopgap
measure.

The one change that has not been brought into the current version is
the #include file change.  I've sent that to the Festival maintainers.

Fix: Attached are three patch files, relative to $WRKDIR.  (I think that's
the format you need to put these in as patches in the files/
directory.)  The first file contains the patches that are in the
current Festival release.  The second contains patches that are not
(but have been sent to them).  The third contains patches that should
only be applied for WITH_OGI.

This first patchfile contains patches that are in the current (but not
yet ported) Festival release.  These are mostly for C++ fixes, plus
one voxware fix to get it to work with artsdsp.
The next patch fixes an #include file location: machine/soundcard.h ->
sys/soundcard.h.  The sys/soundcard.h is preferred since at least
FreeBSD 4.0 and later, but there was a compatibility symlink for
machine/soundcard.h until Mar 2002 in 5.0.
The last patch should only be applied if the user has WITH_OGI
defined.
Comment 1 Trevor Johnson freebsd_committer freebsd_triage 2003-03-09 22:28:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->trevor

to maintainer (me)
Comment 2 Jack Twilley 2003-05-07 01:51:08 UTC 
The current version of festival (1.4.3) includes all of the patches
attached to the ports/49056 except for the machine/soundcard.h ->
sys/soundcard.h patch.  I do not use the OGI functionality, so I
cannot vouch for that patch.

Jack.
-- 
Jack Twilley
jmt at twilley dot org
http colon slash slash www dot twilley dot org slash tilde jmt slash
Comment 3 joelh 2003-05-10 05:22:03 UTC 
> The current version of festival (1.4.3) includes all of the patches
> attached to the ports/49056 except for the machine/soundcard.h ->
> sys/soundcard.h patch.  I do not use the OGI functionality, so I
> cannot vouch for that patch.

Sorry about the delay in response.  It's good to hear that the current
festival is doing well.  It sounds like all that needs to happen on
this PR is for it to get a committer's attention, so we can go to
1.4.3.

When I first submitted it, there was a freeze on; I guess the patches
never made it into FreeBSD, then?

joelh

-- 
Joel Ray Holveck - joelh@gnu.org
   Fourth law of programming:
   Anything that can go wrong wi
sendmail: segmentation violation - core dumped
Comment 4 Volker Stolz freebsd_committer freebsd_triage 2004-12-22 14:58:21 UTC 
State Changed
From-To: open->closed

Issue resolved, we're almost there since updates to 1.4.3 are 
pending in ports/51900 and ports/58653. Thanks for your submission 
and apologies for the, um, delay!
Comment 5 Trevor Johnson freebsd_committer freebsd_triage 2004-12-22 15:09:27 UTC 
State Changed
From-To: closed->open

The patches in the other PRs mentioned are not entirely satisfactory. 
I may want to use these.
Comment 6 Florent Thoumie freebsd_committer freebsd_triage 2005-06-01 10:25:58 UTC 
State Changed
From-To: open->feedback

Could you provide up-to-date patches against current festival 
version ?
Comment 7 Volker Stolz freebsd_committer freebsd_triage 2005-09-16 09:29:27 UTC 
State Changed
From-To: feedback->suspended

Feedback timeout
Comment 8 Trevor Johnson freebsd_committer freebsd_triage 2005-10-17 07:30:54 UTC 
State Changed
From-To: suspended->closed

I updated the port to 1.95 beta, which doesn't need these patches.