Bug 50035

Summary: "make search key" in /usr/ports doesn't show "Info:"
Product: Ports & Packages Reporter: Kirill Ponomarew <ponomarew>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Kirill Ponomarew 2003-03-15 21:50:10 UTC 
"make search key" in /usr/ports doesn't show "Info:" 

voodoo$ cd /usr/ports; make search key=mutt | grep -i ^info
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description
Info:   ** No Description

Is it now default behaviour after removing pkg-comment files ? 

cvsup with ports-supfile was made today

Fix: 

don't know
How-To-Repeat:        eg - cd /usr/ports; make search key=mutt
Comment 1 Olivier Tharan 2003-03-18 14:34:11 UTC 
* Kirill Ponomarew <ponomarew@oberon.net> (20030315 21:55):
> >Description:
> "make search key" in /usr/ports doesn't show "Info:" 
[...]
> Is it now default behaviour after removing pkg-comment files ? 

I guess so, I have been bitten bi this too.

> >Fix:
> don't know

I propose the following, untested and probably not very clean:

--- /usr/ports/Mk/bsd.port.mk   Wed Mar 12 09:27:45 2003
+++ bsd.port.mk Tue Mar 18 15:28:32 2003
@@ -3754,8 +3754,8 @@
 describe: generate-commentfile
        @${ECHO_CMD} "`perl -e ' \
                print q{${PKGNAME}|${.CURDIR}|${PREFIX}|}; \
-               if (open(COMMENT, q{${COMMENTFILE}})) { \
-                       $$_ = <COMMENT>; \
+               if (grep "^COMMENT=[:space:]*(.*)", q{${MAKEFILE}})) { \
+                       $$_ = $1; \
                        chomp; \
                        print; \
                } else { \

(we basically replace a file read by a grep in the Makefile). I am not
sure $MAKEFILE refers to the port Makefile, and the grep syntax is not
good.

-- 
olive
Comment 2 Tilman Keskinoz freebsd_committer freebsd_triage 2003-03-22 21:03:01 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Over to Maintainers
Comment 3 Kris Kennaway 2003-04-13 04:25:52 UTC 
This should probably use make -V COMMENT instead.  I don't think the
current patch is suitable for committing.  Can someone please
investigate further?

Kris
Comment 4 Kris Kennaway freebsd_committer freebsd_triage 2003-04-13 04:25:55 UTC 
State Changed
From-To: open->suspended

Awaiting updated patch
Comment 5 Kris Kennaway freebsd_committer freebsd_triage 2003-04-13 04:26:11 UTC 
State Changed
From-To: suspended->feedback

Feedback is a more appropriate state for this
Comment 6 Kirill Ponomarew 2003-04-13 07:06:42 UTC 
Hi,

On Sat, Apr 12, 2003 at 08:25:52PM -0700, Kris Kennaway wrote:
> This should probably use make -V COMMENT instead.  I don't think the
> current patch is suitable for committing.  Can someone please
> investigate further?

This problem came from "portsdb -U", I don't know whether knu@
fixed it or not. Instead of "portsdb -U", I tried "cd /usr/ports
&& make index", and it worked.

Kirill
Comment 7 Kris Kennaway freebsd_committer freebsd_triage 2003-05-10 23:39:20 UTC 
State Changed
From-To: feedback->closed

Submitter reported the problem is no longer seen in 'make index'