Bug 50271

Summary: Add USB ID/quirks for Optio 230GS Digital Camera
Product: Base System Reporter: Oliver Brandmueller <obi>
Component: kernAssignee: njl
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.8-PRERELEASE   
Hardware: Any   
OS: Any   

Description Oliver Brandmueller 2003-03-25 10:00:26 UTC
I've successfully connected a Pentax Optio 230GS camera with the same 
options/quirks as the Optio 230 camera which is already mentioned in the 
sources.

Fix: 

In /usr/src/sys/dev/usb/usbdevs add:

product ASAHIOPTICAL OPTIO230GS	0x0006  Digital camera


In /usr/src/sys/dev/usb/umass.c add:

        if (UGETW(dd->idVendor) == USB_VENDOR_ASAHIOPTICAL
            && UGETW(dd->idProduct) == USB_PRODUCT_ASAHIOPTICAL_OPTIO230GS) {
                sc->quirks |= RS_NO_CLEAR_UA;
        }


After rebuilding usbdevs.h and building/installing the new kernel the 
camera works just fine as a umass device.
How-To-Repeat: connect Optio 230GS camera to USB port
Comment 1 Johan Karlsson freebsd_committer freebsd_triage 2003-03-25 18:43:29 UTC
Responsible Changed
From-To: freebsd-bugs->njl

Over to quirks maintainer.
Comment 2 Nate Lawson 2003-04-27 20:54:50 UTC
I need some more information from you.  Please send the results of
camcontrol inquiry <your device> after it has successfully attached as
well as output of "usbdevs -v".

Instead of your patch, please try the following:

--- src/sys/dev/usb/umass.c     14 Mar 2003 13:23:05 -0000      1.11.2.18
+++ src/sys/dev/usb/umass.c     27 Apr 2003 19:52:14 -0000
@@ -616,10 +616,8 @@
         * The Pentax Optio 230 requires RS_NO_CLEAR_UA
         * PR: kern/46369
         */
-       if (UGETW(dd->idVendor) == USB_VENDOR_ASAHIOPTICAL
-           && UGETW(dd->idProduct) == USB_PRODUCT_ASAHIOPTICAL_OPTIO230) {
+       if (UGETW(dd->idVendor) == USB_VENDOR_ASAHIOPTICAL)
                sc->quirks |= RS_NO_CLEAR_UA;
-       }
 
        if (UGETW(dd->idVendor) == USB_VENDOR_FUJIPHOTO
            && UGETW(dd->idProduct) == USB_PRODUCT_FUJIPHOTO_MASS0100) {
Comment 3 njl freebsd_committer freebsd_triage 2003-04-27 20:54:57 UTC
State Changed
From-To: open->feedback

Submitter will test patch and report back.
Comment 4 njl freebsd_committer freebsd_triage 2003-05-17 22:59:29 UTC
State Changed
From-To: feedback->closed


Generalized quirk (all of Asahi Optical devices) has been committed and 
MFCd.  It will be in 5.1R and subsequent 4.x releases.