Bug 50670

Summary: Add some voodoo magic to security/tripwire
Product: Ports & Packages Reporter: Miguel Mendez <flynn>
Component: Individual Port(s)Assignee: Cy Schubert <cy>
Status: Closed FIXED    
Severity: Affects Only Me CC: cy
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
tripwire.diff none

Description Miguel Mendez 2003-04-07 12:10:04 UTC
Wouldn't it be nice it the tripwire install automagically chose the right
mail program from /etc/mail/mailer.conf? :)
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2003-04-07 13:51:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cy

My port.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2003-04-07 13:52:51 UTC
State Changed
From-To: open->analyzed

Tripwire already works with Postfix, e.g., 

sendmail        /usr/local/sbin/sendmail 

cwfw$ ls -l /usr/sbin/sendmail  
lrwxr-xr-x  1 root  wheel  21 Apr  4 20:50 /usr/sbin/sendmail -> /usr/sbin/mailwrapper 
cwfw$ /usr/sbin/sendmail -bs 
220 mail.komquats.com ESMTP Postfix 
quit 
221 Bye 
cwfw$  

Locally, I've been running tripwire with postfix for over a year without 
the patch in this PR. 

Unless given a good reason to do so, this PR will be closed. Awaiting 
comment from submittor.
Comment 3 corecode@corecode.ath.cx 2003-04-07 19:15:42 UTC
Lately Miguel Mendez told:

> >Description:
> Wouldn't it be nice it the tripwire install automagically chose the
> right mail program from /etc/mail/mailer.conf? :)

yea

> diff -ruN tripwire.old/Makefile tripwire/Makefile
> --- tripwire.old/Makefile	Fri Mar  7 07:10:50 2003
> +++ tripwire/Makefile	Mon Apr  7 13:02:22 2003
[...]
> @@ -21,10 +21,13 @@
>  WRKSRC=		${WRKDIR}/${DISTNAME}
>  BUILD_WRKSRC=	${WRKSRC}/src
>  USE_GMAKE=	yes
> +USE_REINPLACE=	yes
>  ALL_TARGET=	release
>  MAKE_ARGS=	SYSPRE=${ARCH}-unknown-freebsd
>  IS_INTERACTIVE=	yes
>  
> +MAILER!= grep ^sendmail /etc/mail/mailer.conf | awk '{print $2}'
> +

ugh... this means this needs to be run every make, not every build.
dunno if this might break kris' INDEX foo...
how about:

post-patch:
	@mailer="${MAILER}"; \
	[ -z "$$mailer" ] && mailer=`${AWK} '/^sendmail/{print $2}' /etc/mail/mailer.conf`; \
	${REINPLACE_CMD} -e "s,/usr/sbin/sendmail,$$mailer," ${WRKSRC}/install/install.cfg

(not tested, out of my [crazy] head)

cheers
  simon

-- 
/"\   http://corecode.ath.cx/#donate
\ /
 \     ASCII Ribbon Campaign
/ \  Against HTML Mail and News
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2003-04-09 03:05:18 UTC
State Changed
From-To: analyzed->closed

Submitter agrees this PR should be closed.
Comment 5 Cy Schubert 2003-04-11 00:13:39 UTC
Oops, should have hit reply all...

Please review review my closing comments for the PR (see 
/etc/mail/mailer.conf).


Cheers,
--
Cy Schubert <Cy.Schubert@komquats.com>        http://www.komquats.com/
BC Government                .   FreeBSD UNIX      .            Inetex
Cy.Schubert@osg.gov.bc.ca    .  cy@FreeBSD.org     .    cys@inetex.com

In message <20030407201542.0c46f38a.corecode@corecode.ath.cx>, "Simon 
'portlint
' Schubert" writes:
> --GdHgF=.c=3+KoJOv
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: 7bit
> 
> Lately Miguel Mendez told:
> 
> > >Description:
> > Wouldn't it be nice it the tripwire install automagically chose the
> > right mail program from /etc/mail/mailer.conf? :)
> 
> yea
> 
> > diff -ruN tripwire.old/Makefile tripwire/Makefile
> > --- tripwire.old/Makefile	Fri Mar  7 07:10:50 2003
> > +++ tripwire/Makefile	Mon Apr  7 13:02:22 2003
> [...]
> > @@ -21,10 +21,13 @@
> >  WRKSRC=		${WRKDIR}/${DISTNAME}
> >  BUILD_WRKSRC=	${WRKSRC}/src
> >  USE_GMAKE=	yes
> > +USE_REINPLACE=	yes
> >  ALL_TARGET=	release
> >  MAKE_ARGS=	SYSPRE=${ARCH}-unknown-freebsd
> >  IS_INTERACTIVE=	yes
> >  
> > +MAILER!= grep ^sendmail /etc/mail/mailer.conf | awk '{print $2}'
> > +
> 
> ugh... this means this needs to be run every make, not every build.
> dunno if this might break kris' INDEX foo...
> how about:
> 
> post-patch:
> 	@mailer="${MAILER}"; \
> 	[ -z "$$mailer" ] && mailer=`${AWK} '/^sendmail/{print $2}' /etc/mail/m
> ailer.conf`; \
> 	${REINPLACE_CMD} -e "s,/usr/sbin/sendmail,$$mailer," ${WRKSRC}/install/
> install.cfg
> 
> (not tested, out of my [crazy] head)
> 
> cheers
>   simon
> 
> -- 
> /"\   http://corecode.ath.cx/#donate
> \ /
>  \     ASCII Ribbon Campaign
> / \  Against HTML Mail and News
> 
> --GdHgF=.c=3+KoJOv
> Content-Type: application/pgp-signature
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.0 (GNU/Linux)
> 
> iD8DBQE+kcBSr5S+dk6z85oRAjxrAKD8X+A9OSI+VGnVWqaCJRpQticzwACgqkww
> 4Uzv2Z/F7M3WWJXQBBVmoz8=
> =Yo2J
> -----END PGP SIGNATURE-----
> 
> --GdHgF=.c=3+KoJOv--