Bug 51421
| Summary: | CD-burning problems with Plextor PX-W1210A drive | ||
|---|---|---|---|
| Product: | Base System | Reporter: | J.Porter Clark <jpc> |
| Component: | i386 | Assignee: | Thomas Quinot <thomas> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | 4.8-STABLE | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
J.Porter Clark
2003-04-25 21:20:02 UTC
Responsible Changed From-To: freebsd-bugs->thomas I know that there are problems with some new drives and DAO mode, it is on my TODO list. For the ATAPICAM problem I transfer this to thomas. Le 2003-04-25, J.Porter Clark écrivait : > If I use atapicam/cdrecord instead, everything works, even DAO mode. > But there is one horrible side effect: If I boot the system with > nothing in the CD drive, it panics! Thanks for the trap message and backtrace, they are most useful indeed. Please try the patch below. Thanks, Thomas. Index: atapi-cam.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/atapi-cam.c,v retrieving revision 1.10.2.2 diff -u -r1.10.2.2 atapi-cam.c --- atapi-cam.c 3 Mar 2003 19:11:38 -0000 1.10.2.2 +++ atapi-cam.c 12 May 2003 16:39:09 -0000 @@ -168,7 +168,14 @@ void atapi_cam_reinit_bus(struct ata_channel *ata_ch) { struct atapi_xpt_softc *scp = get_softc(ata_ch); - reinit_bus(scp, RESET); + + /* + * scp might be null if the bus is being reinitialised during + * the boot-up sequence, before the ATAPI bus is registered. + */ + + if (scp != NULL) + reinit_bus(scp, RESET); } static void -- Thomas.Quinot@Cuivre.FR.EU.ORG ----- Forwarded message from "J. Porter Clark" <jpc@drum.msfc.nasa.gov> ----- Date: Tue, 13 May 2003 13:25:53 -0500 From: "J. Porter Clark" <jpc@drum.msfc.nasa.gov> To: Thomas Quinot <thomas@FreeBSD.ORG> Subject: Re: i386/51421: CD-burning problems with Plextor PX-W1210A drive In-Reply-To: <20030512164035.GA77779@melusine.cuivre.fr.eu.org> On Mon, May 12, 2003 at 06:40:35PM +0200, Thomas Quinot wrote: > > Le 2003-04-25, J.Porter Clark ?crivait : > > > If I use atapicam/cdrecord instead, everything works, even DAO mode. > > But there is one horrible side effect: If I boot the system with > > nothing in the CD drive, it panics! > > Thanks for the trap message and backtrace, they are most useful indeed. > Please try the patch below. Hooray! It works! Many thanks! If I boot without a CD in the drive, there is no panic. I did see a new message on the console. It looks like a benign warning. It is the last line of the following: cd0 at ata0 bus 0 target 0 lun 0 cd0: <PLEXTOR CD-R PX-W1210A 1.08> Removable CD-ROM SCSI-0 device cd0: 16.000MB/s transfers cd0: Attempt to query device size failed: NOT READY, Medium not present - tray closed -- J. Porter Clark jpc@drum.msfc.nasa.gov NASA/MSFC Computers and Data Systems Group (ED13) ----- End forwarded message ----- -- Thomas.Quinot@Cuivre.FR.EU.ORG [ Please be sure to always Cc: bug-followup@freebsd.org when following up on a PR, so as to ensure that the exchange is appropriately tracked and receives due attention. ] Le 2003-05-13, J. Porter Clark écrivait : > Hooray! It works! Many thanks! > If I boot without a CD in the drive, there is no panic. OK, this change is now part of FreeBSD 5 and will be present in the upcoming 5.1-RELEASE. It should be merged into the FreeBSD 4 branch in one week (unless a problem with it shows up in the meantime). > cd0: Attempt to query device size failed: NOT READY, Medium not present - tray closed This looks perfectly legitimate if there is no disc in the drive. Thank you for your help with improving FreeBSD! Thomas. -- Thomas.Quinot@Cuivre.FR.EU.ORG Revision Changes Path
1.16 +8 -1 src/sys/dev/ata/atapi-cam.c
--
Thomas.Quinot@Cuivre.FR.EU.ORG
State Changed From-To: open->closed Patch committed. |
