Bug 53791
| Summary: | Can't pass CPPFLAGS to configure when WITH_QT_VER setted (patch) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sergey Matveychuk <sem> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | kde | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->kde over to maintainers State Changed From-To: open->feedback What's wrong with appending to QTCPPFLAGS? Also, do you think a similar thing should be added to QTCFGLIBS/LIBS (i.e. add LDFLAGS to that passed variable? Hi Will, Hi Sem, IIRC, Will told me on IRC that there were private followups to this PR between you two, which ended in an improved patch. Unfortunately this PR is still open. So I would like to see the improved patch too, either in my Inbox or in my cvsup :-) regards tilman State Changed From-To: feedback->closed Should be fixed with the 3.2.0 commit. Thanks for reporting! |
My port can build WITH_QT or without it. Also I pass CPPFLAGS to 'configure' by CONFIGURE_ENV. When I don't set WITH_QT all goes right, when I don't set it I loss CPPFLAGS in 'configure'. It's happened because these lines in bsd.kde.mk: CONFIGURE_ENV+= CPPFLAGS="${QTCPPFLAGS}" that overrides my CPPFLAGS settings. The followed patch fix it. I think it's unpainful for other KDE stuff. It's important for my port. So let me know if it's possible to commit it soon, please.