Bug 54174

Summary: clean spaces behind variables out of port Makefiles
Product: Ports & Packages Reporter: Oliver Lehmann <oliver>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me CC: oliver
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
clean.sh none

Description Oliver Lehmann freebsd_committer freebsd_triage 2003-07-07 12:00:27 UTC 
	There are some ports where the Makefile contains at least
	one line similar to the following lines:
MAN1 =	something.1
MAN1=     something.1
MAN1= 	something
MAN1=  	something
	Regarding to portlint and porters-handbook, each of those 
	constructs are "wrong" (bacause there are spaces between
	or in front of = and the assignment). Find the script
	which tries to repair this attached.
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2003-11-16 13:13:59 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

portmgr should take a look at it
Comment 2 edwin 2004-01-10 02:17:45 UTC 
That's lang/gawk, not the awk from the base system (at least on ref5)

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/
Comment 3 edwin 2004-01-10 02:36:41 UTC 
Please be a little conservative what you actually process, i.e. not
all Makefiles are ports Makefiles: ports/audio/afsp/files/Makefile:

	test -z "`grep ^PORTNAME= ${file}`" && continue 

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/
Comment 4 Kris Kennaway freebsd_committer freebsd_triage 2004-05-19 05:02:49 UTC 
State Changed
From-To: open->analyzed

This will not be run on the ports collection because it will 
invalidate a lot of patches for no functional gain.  It should either 
be added to Tools/ or merged into portlint.
Comment 5 Kris Kennaway freebsd_committer freebsd_triage 2004-05-19 05:29:27 UTC 
State Changed
From-To: analyzed->closed

Close the port instead since there's nothing further for portmgr to do.