Bug 54572

Summary: [patch] unbreak b0rked www/en/ports/index.sgml
Product: Documentation Reporter: Josef El-Rayes <j.el-rayes>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
index.sgml.diff none

Description Josef El-Rayes 2003-07-17 11:10:14 UTC
	build of webpages breaks because of empty <UL></UL>

How-To-Repeat: 	try to build webpages
Comment 1 Marc Fonvieille freebsd_committer freebsd_triage 2003-07-17 11:30:07 UTC
On Thu, Jul 17, 2003 at 12:09:49PM +0200, Josef El-Rayes wrote:
[...]
> 	
> 
> --- index.sgml.diff begins here ---
> --- index.sgml.orig	Thu Jul 17 11:39:21 2003
> +++ index.sgml	Thu Jul 17 11:56:00 2003
> @@ -12,8 +12,6 @@
>  FreeBSD Ports Collection.<br> <A HREF="ftp://ftp.FreeBSD.org/pub/FreeBSD/branches/-current/ports.tar.gz">Download
>  a gzip'd tar file of all  ports</A> (about 19 megabytes) or
>  browse the following categories:
> -<UL>
> -</UL>
>  <UL><LI><A HREF="master-index.html">Alphabetical list of all  ports</A></LI></UL>
>

In fact, there is no index.sgml.  This later is generated with
portindex; the following patch should fix the problem:

Index: portindex
===================================================================
RCS file: /home/dcvs/www/en/ports/portindex,v
retrieving revision 1.47
diff -u -r1.47 portindex
--- portindex	10 Jul 2003 21:41:29 -0000	1.47
+++ portindex	17 Jul 2003 10:29:24 -0000
@@ -226,7 +226,7 @@
 a gzip'd tar file of all $portnumber ports</A> (about 19 megabytes) or
 browse the following categories:\n";
 
-    print MOUTF "<UL>\n";
+#    print MOUTF "<UL>\n";
 
     @foos = sort(keys %stats);
     foreach $key  (@foos) {
@@ -262,7 +262,7 @@
 	close(OUTF);
 
     }
-    print MOUTF "</UL>\n";
+#    print MOUTF "</UL>\n";
     print MOUTF 
     	"<UL><LI><A HREF=\"master-index.html\">Alphabetical list of all $portnumber ports</A></LI></UL>\n";
     &footer(MOUTF, "");

Marc
Comment 2 Ceri Davies freebsd_committer freebsd_triage 2003-07-17 11:46:30 UTC
On Thu, Jul 17, 2003 at 12:09:49PM +0200, Josef El-Rayes wrote:

> >Description:
> 	build of webpages breaks because of empty <UL></UL>

This shouldn't be breaking the build, and doesn't on my machine.

Could you please followup with the error from make?

Thanks,

Ceri
-- 
User: DO YOU ACCEPT JESUS CHRIST AS YOUR PERSONAL LORD AND SAVIOR?
Iniaes: Sure, I can accept all forms of payment.
                                           -- www.chatterboxchallenge.com
Comment 3 Josef El-Rayes 2003-07-17 12:08:11 UTC
Ceri Davies <ceri@FreeBSD.org> wrote:
>  This shouldn't be breaking the build, and doesn't on my machine.
>  Could you please followup with the error from make?

my local repository is in sync with the cvs (15minutes ago...)

root@daemon:/usr/www/en/ports>make
cd /usr/www/en/ports;  make  -f /usr/www/en/ports/Makefile.inc0 all
/usr/bin/sed -e 's/<!ENTITY date[ \t]*"$Free[B]SD. .* \(.* .*\) .* .*
$">/<!ENTITY date "Last modified: \1">/'  index.sgml |  /usr/bin/env
SGML_CATALOG_FILES=  /usr/local/bin/sgmlnorm -d  -c
/usr/local/share/sgml/html/catalog -D /usr/www/en/ports > index.html ||
(/bin/rm -f index.html && false)
/usr/local/bin/sgmlnorm:<OSFD>0:16:4:E: end tag for "UL" which is not
finished
*** Error code 1
 
Stop in /usr/www/en/ports.
*** Error code 1
 
Stop in /usr/www/en/ports.

this is why i edited the .sgml. i did not know that the sgml gehts
autogenerated, i should have done a make clean before trying to solve
the issue. my error.

greets, josef

-- 
www: http://www.daemon.li
nic-hdl: JER1080312-NICAT
FreeBSD PortMaintainer 
"Make World - Not War!"
Comment 4 josef freebsd_committer freebsd_triage 2004-01-15 21:07:23 UTC
State Changed
From-To: open->closed

The submitter(me) says this PR can be closed.