Bug 56083

Summary: Update ethereal to version 0.9.14 and allow for gtk2
Product: Ports & Packages Reporter: Rolf Grossmann <grossman>
Component: Individual Port(s)Assignee: bill fumerola <billf>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Rolf Grossmann 2003-08-28 14:40:00 UTC 
The given patch will update ethereal to version 0.9.14 and while I was at it,
I also added some support for using gtk2 instead of the old gtk. I know the
old gtk libraries are not going away any time soon, but I'm still trying not
having to use them. The code is trying to detect which version is installed,
defaulting to the existing (old) gtk. Just look at the patch.

Best regards, Rolf

How-To-Repeat: 	Install ethereal port.
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2003-08-28 14:59:32 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->billf

Over to maintainer.
Comment 2 Brian Feldman freebsd_committer freebsd_triage 2003-12-17 14:45:32 UTC 
State Changed
From-To: open->feedback

Would you mind taking the current ethereal 0.10.0a port and seeing if 
your GTK2 changes apply and work correctly?
Comment 3 Rolf Grossmann 2003-12-29 19:58:59 UTC 
I've now had a chance to look at the current ethereal port. Looks like 
someone beat me to the WITH_GTK2 option, however, I believe 
USE_GNOME=gtk20 is preferred to directly specifying LIB_DEPENDS. Also, I 
would like to keep the automatic detection of gtk2 to ease the migration 
to gnome2. See below for an updated patch.

As for the "work correctly", I have one small problem in that the 
capture window would only refresh (and update) when packets are 
received. I'm not sure if that's a gtk2 specific problem, but it might 
well be. It would still be helpful if others could verify that problem, 
as I probably won't have the time to track it down (and frankly, it 
doesn't really bother me too much).

Rolf

--- Makefile.orig    Wed Dec 17 17:40:13 2003
+++ Makefile    Mon Dec 29 20:43:26 2003
@@ -18,17 +18,20 @@
 MAINTAINER=    billf@FreeBSD.org
 COMMENT=    An X11/GTK network analyzer/capture tool
 
+USE_BZIP2=    yes
+WANT_GNOME=    yes
+.include <bsd.port.pre.mk>
+
 .if !defined(WITHOUT_SNMP)
 LIB_DEPENDS=    netsnmp.6:${PORTSDIR}/net/net-snmp
 .endif
 
-USE_BZIP2=    yes
 CONFIGURE_ARGS=    --program-transform-name=""
 CONFIGURE_TARGET=    --target=${MACHINE_ARCH}-unknown-freebsd${OSREL}
 .if !defined(WITHOUT_X11)
 USE_X_PREFIX=    yes
-.if defined(WITH_GTK2)
-LIB_DEPENDS+=    gtk-x11-2.0:${PORTSDIR}/x11-toolkits/gtk20
+.if defined(WITH_GTK2) || (${HAVE_GNOME:Mgtk20}!="")
+USE_GNOME=    gtk20
 CONFIGURE_ARGS+=    --enable-gtk2=yes
 .else
 USE_GNOME=    gtk12
@@ -60,4 +63,4 @@
 MAN1+=        editcap.1 idl2eth.1 mergecap.1 tethereal.1 text2pcap.1
 MAN4+=        ethereal-filter.4
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-02-28 22:58:33 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!