Bug 57502
| Summary: | ports that define USE_* too late | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oliver Eikemeier <eikemeier> | ||||
| Component: | Individual Port(s) | Assignee: | Tom McLaughlin <tmclaugh> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Oliver Eikemeier
2003-10-02 17:40:18 UTC
On Thu, 02 Oct 2003 18:31:53 +0200 Oliver Eikemeier <eikemeier@fillmore-labs.com> wrote: Hi Oliver !! Thank you for the notification :) Great job too :) I'll fix it tomorrow, regards, clem On Thu, 2 Oct 2003, Oliver Eikemeier wrote: > * USE_OPENSSL: > > DougB@FreeBSD.org > - dns/bind9 (PR 57495) Fixed. -- This .signature sanitized for your protection A patch that for bsd.port.mk that fixes the ports listed under USE_OPENLDAP is in PR 57529. Oliver Eikemeier wrote:
> A patch that for bsd.port.mk that fixes the ports
> listed under USE_OPENLDAP is in PR 57529.
Strong am I with the Source, but not that strong...
Multiple ports define USE_* variables that are tested in bsd.port.pre.mk *after* they include bsd.port.pre.mk, which results in that that directive being ignored. Updated list (now that we have portlint support ;-): 3d@freebsd.org - games/linux-q3ademo (USE_X_PREFIX) avleeuwen@piwebs.com - audio/yammi (USE_KDELIBS_VER) brueffer@phoenix-systems.de - net/simicq (USE_OPENSSL, USE_KDELIBS_VER) cyrille.lefevre@laposte.net textproc/docbook-to-man (USE_IMAKE, USE_X_PREFIX) desmo@bandwidth.org x11-clocks/xalarm (USE_IMAKE, broken by kris@ in an efford to break it only on 5.x :) ) gnome@FreeBSD.org - irc/xchat2 (USE_PYTHON) goto@snowy.to - irc/ircatlite (USE_X_PREFIX, broken by kris@ in an efford to break it only on 5.x :) ) jeremy@external.org - sysutils/ipsc (USE_X_PREFIX) jim@FreeBSD.org - irc/xchat (USE_OPENSSL, USE_PYTHON) jmz@FreeBSD.org - games/qix (USE_X_PREFIX) - x11/xgrab (USE_IMAKE) jylefort@brutele.be - mail/sylpheed-gtk2 (USE_OPENSSL) lofi@freebsd.org - security/pinentry (USE_QT_VER) obrien@FreeBSD.org - editors/vim (USE_PYTHON, USE_RUBY) ports@FreeBSD.org - databases/mdbtools (USE_X_PREFIX) - x11-toolkits/viewklass (USE_X_PREFIX) sysadmin@alexdupre.com - databases/mysql41-server (USE_OPENSSL) >>>>> Oliver Eikemeier writes: > Multiple ports define USE_* variables that are tested in bsd.port.pre.mk > *after* they include bsd.port.pre.mk, which results in that that directive > being ignored. Updated list (now that we have portlint support ;-): > - games/qix (USE_X_PREFIX) Not in this case. Jean-Marc -- Jean-Marc Zucconi -- PGP Key: finger jmz@FreeBSD.org [KeyID: 400B38E9] Jean-Marc Zucconi wrote:
>>>>>>Oliver Eikemeier writes:
>
> > Multiple ports define USE_* variables that are tested in bsd.port.pre.mk
> > *after* they include bsd.port.pre.mk, which results in that that directive
> > being ignored. Updated list (now that we have portlint support ;-):
>
> > - games/qix (USE_X_PREFIX)
>
> Not in this case.
Sorry, you're right. Do you think we should try to fix portlint? Or would you prefer:
.if defined(WITHOUT_X11)
MAKE_ARGS= NO_X11=yes
.else
USE_X_PREFIX= yes
PLIST= pkg-plist.x11
.endif
.include <bsd.port.pre.mk>
just in case?
Responsible Changed From-To: freebsd-ports-bugs->eik Submitter is now committer. Your docbook-to-man port is still not corrected. USE_IMAKE implies USE_X_PREFIX, so the latter can be removed. USE_IMAKE should be set before bsd.port.pre.mk inclusion. In general, non-conditional variable assignments should be done before its inclusion. Do you agree with these changes ? -- Florent Thoumie flz@xbsd.org State Changed From-To: open->suspended With bugmeister hat on, reassign from inactive committer. The infrastructure problem that eik noted is now something that's checked for in portlint (see ports/57496) but I have not checked to see if all the ports that were oringally cited by this PR have been closed. I'll mark this suspended in case someone wants to do the detective work. Responsible Changed From-To: eik->freebsd-ports-bugs State Changed From-To: suspended->open All the ports listed in this PR except textproc/docbook-to-man are fine today. Now I just need to figure out what the hell is going on in that one remaining port. Global and local variables, huh? Responsible Changed From-To: freebsd-ports-bugs->tmclaugh All the ports listed in this PR except textproc/docbook-to-man are fine today. Now I just need to figure out what the hell is going on in that one remaining port. Global and local variables, huh? Attached patch is the final fix needed to close this PR. Will commit after ports freeze is over. State Changed From-To: open->closed Committed final patch. tmclaugh 2008-04-18 02:30:16 UTC
FreeBSD ports repository
Modified files:
textproc/docbook-to-man Makefile
Log:
- pet portlint
PR: 57502
Revision Changes Path
1.13 +10 -11 ports/textproc/docbook-to-man/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
