Bug 57586
| Summary: | [patch] Make security/sfs compile on -current | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | edwin |
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | handler |
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
A follow up can be found at ports/57599 State Changed From-To: open->closed Committed, thanks. |
security/sfs doesn't build on -current due to problems with: random_prime.C: In member function `bigint& prime_finder::next_strong(unsigned int)': random_prime.C:339: warning: comparison is always false due to limited range of data type (http://bento.freebsd.org/errorlogs/i386-5-latest/sfs-0.7.2.log) Fix: The function fermat2_test() does return true when (some calculated value) equals 2. It looks like a leftover from a historical change. Maintainer (cc:d), please approve this patch. In the mean time, I'm going to find out whats wrong with it to get ports/57251 fixed. (http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/57251)--Ncul5l7wKP0cSJ7ge1icXNc96Vwsez5Vf013pDeVqmfxgC4u Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" --- crypt/random_prime.C.orig Sat Oct 4 18:14:40 2003 +++ crypt/random_prime.C Sat Oct 4 18:14:54 2003 @@ -336,7 +336,7 @@ bigint t1, t2; for (;;) { next_weak (); - if (!tmp || (fermat2_test (tmp, &t1, &t2) == 2 && tmp.probab_prime (iter))) + if (!tmp || (fermat2_test (tmp, &t1, &t2) && tmp.probab_prime (iter))) return tmp; } } How-To-Repeat: -