Bug 59013

Summary: audio/ripit: Add http proxy support
Product: Ports & Packages Reporter: Simon Barner <barner>
Component: Individual Port(s)Assignee: Pav Lucistnik <pav>
Status: Closed FIXED    
Severity: Affects Only Me CC: oyvindmo
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Simon Barner 2003-11-06 16:00:36 UTC
This makes ripit use a http proxy if the HTTP_PROXY environment variable
is set.

Please test this also with non-proxy http und plain cddb mode - I cannot
do that since I am behind a rigid firewall (hence the patch :-)

I have also mailed the (tiny) diff to the author of the script.

How-To-Repeat: 
N/A
Comment 1 Pav Lucistnik freebsd_committer 2003-11-17 19:30:17 UTC
Dear FreeBSD port maintainer,

please take a look at 

http://www.freebsd.org/cgi/query-pr.cgi?pr=59013

Do you approve this change?

-- 
Pav Lucistnik <pav@FreeBSD.org>
              <pav@oook.cz>
Comment 2 Pav Lucistnik freebsd_committer 2003-11-17 19:40:33 UTC
State Changed
From-To: open->feedback

I'll take care of this. 


Comment 3 Pav Lucistnik freebsd_committer 2003-11-17 19:40:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

I'll take care of this.
Comment 4 Oyvind Moll 2003-11-17 22:19:23 UTC
* pav@FreeBSD.org:
| 
| Dear FreeBSD port maintainer,
| 
| please take a look at 
| 
| http://www.freebsd.org/cgi/query-pr.cgi?pr=59013
| 
| Do you approve this change?

The HTTP proxy change seems fine.

However, the patch in the PR also includes a change of perl
interpreter path from /usr/bin/perl to /usr/local/bin/perl.  This
change should _not_ be applied.  The correct perl path is set through
the use of USE_PERL5 and the post-patch target in the port Makefile.

-- 
   Øyvind Møll
   oyvindmo@initio.no
Comment 5 Simon Barner 2003-11-17 23:21:46 UTC
> The HTTP proxy change seems fine.
> 
> However, the patch in the PR also includes a change of perl
> interpreter path from /usr/bin/perl to /usr/local/bin/perl.  This
> change should _not_ be applied.  The correct perl path is set through
> the use of USE_PERL5 and the post-patch target in the port Makefile.

Oops, sorry. I use the perl5.8 port, and I modified the installed
version of the script to produce my patch. Unfortunately, I did not
review the patch file, this is why this hunk was also submitted.

Simon
Comment 6 Pav Lucistnik freebsd_committer 2003-11-17 23:45:53 UTC
State Changed
From-To: feedback->closed

Committed without shebang change, but with a portrevision bump. 
Thanks!