Bug 59044

Summary: [patch] doc.docbook.mk does not properly handle a source document already in XML format.
Product: Documentation Reporter: Mike Edenfield <kutulu>
Component: Books & ArticlesAssignee: Gabor Kovesdan <gabor>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
docbook.patch none

Description Mike Edenfield 2003-11-07 22:40:09 UTC
The documentation project makefiles are set up to allow the author
to apply XSL stylesheets instead of DSSSL stylesheet, and to use
DocBook 4.2 in XML format.  However, the makefiles assume that the
source document is in SGML format and needs to be converted to XML
format first.

This step itself is actually broken, as it assumes the document
has a root node of <book>, which is not always the case.  As it
stands, there's no way around this problem because using a pre-
make XML file fails for the reason below.

If the source document is already in XML format, this step is not
needed, and in fact causes a cyclic dependancy of the master
document on itself.

With this patch applied, one can use either the XML or SGML forms
of the DocBook DTD.

The patch also fixes a bug in the XSLT processing which fails to 
generate the HTML.manifest document, even though it assumes the 
file is present during `make clean` and while running tidy.

How-To-Repeat: --- Makefile:
DOC= article
DOCBOOKSUFFIX= xml
STYLESHEET_TYPE= xsl
SRCS= article.xml
.include "/usr/doc/share/mk/doc.project.mk"

~: $ make
Graph cycles through article.xml.
Comment 1 Gabor Kovesdan freebsd_committer freebsd_triage 2012-09-14 15:56:37 UTC
State Changed
From-To: open->closed

With time the SGML format became obsolete and now we only 
support XML.  Thanks for taking your time to send a patch, though! 


Comment 2 Gabor Kovesdan freebsd_committer freebsd_triage 2012-09-14 15:56:37 UTC
Responsible Changed
From-To: freebsd-doc->gabor

Track.