Bug 59076

Summary: An update for multimedia/xmms port (new knob)
Product: Ports & Packages Reporter: oleg dashevskii <be9-ml>
Component: Individual Port(s)Assignee: Pav Lucistnik <pav>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
xmms.patch
none
xmms.patch
none
xmms.diff none

Description oleg dashevskii 2003-11-09 12:20:16 UTC 
Introducing a new Makefile knob: WITH_ENCODING_PATCH
Allows for automatic Russian encoding detection in ID3 tags, filenames, etc
The knob will be used by russian/xmms port which comes in the next PR.
Comment 1 Espen Skoglund 2003-11-17 14:04:55 UTC 
I am not able to fetch the patchfile.  I would also strongly suggest
using PATCHFILES and PATCH_SITES for this kind of stuff.  As for
checking whether the patch itself is sane, I don't think I am the
right person for checking this.

	eSk
Comment 2 oleg dashevskii 2003-11-17 15:31:38 UTC 
On Mon, Nov 17, 2003 at 03:19:29PM +0100, Oliver Eikemeier wrote:

> > I am not able to fetch the patchfile.  I would also strongly suggest
> > using PATCHFILES and PATCH_SITES for this kind of stuff.  As for

No way. Here's a quote from porter's handbook:

"If the patch is distributed with some other files, such as
documentation, in a gzip'd tarball, you cannot just use PATCHFILES. If
that is the case, add the name and the location of the patch tarball to
DISTFILES and MASTER_SITES."

That's exactly the reason for me using MASTER_SITES.

> > checking whether the patch itself is sane, I don't think I am the
> > right person for checking this.

> Seems to be an reasonable alternative. Close?

As for unfetchable distfile, the last update in bsd.port.mk seems to
have broken the grouping feature. Attached is a new version of patch.

--
be9
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2003-11-26 14:30:43 UTC 
State Changed
From-To: open->feedback

Maintainer advised
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2003-11-26 15:28:57 UTC 
Dear maintainer, could you approve or disaprove PR 59076
 <http://www.freebsd.org/cgi/query-pr.cgi?pr=59076>
Thanks,

-- 
Mathieu Arnold
Comment 5 Espen Skoglund 2003-11-26 18:43:20 UTC 
Here's a less intrusive version of the patch.  Note that doing
"subdir:group" for MASTER_SITE_SUBDIR does for some reason not work.
A little workaround (hack) is therefore required.
Comment 6 oleg dashevskii 2003-11-26 18:55:29 UTC 
On Wed, Nov 26, 2003 at 07:43:20PM +0100, Espen Skoglund wrote:
Content-Description: message body text
> Here's a less intrusive version of the patch.  Note that doing
> "subdir:group" for MASTER_SITE_SUBDIR does for some reason not work.
> A little workaround (hack) is therefore required.

Ah, that's ok. I used :dist due to the same reason of something having
been broken. More intrusive, less hack. You preferred less intrusive,
more hack, that's it. :-)

--
be9
Comment 7 Pav Lucistnik freebsd_committer freebsd_triage 2003-11-26 20:14:49 UTC 
State Changed
From-To: feedback->open

Feedback received.
Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2003-11-27 01:14:13 UTC 
State Changed
From-To: open->analyzed

I'll commit this after the freeze.
Comment 9 Pav Lucistnik freebsd_committer freebsd_triage 2003-11-27 01:14:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

I'll commit this after the freeze.
Comment 10 Pav Lucistnik freebsd_committer freebsd_triage 2003-12-04 10:42:57 UTC 
State Changed
From-To: analyzed->closed

Committed, thanks!