Bug 59289
| Summary: | [bktr] [patch] ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Daan Vreeken [PA4DAN] <Danovitsch> | ||||
| Component: | kern | Assignee: | Josh Paetzel <jpaetzel> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jpaetzel | ||||
| Priority: | Normal | ||||||
| Version: | 5.1-RELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-bugs->roger Over to bktr maintainer. Responsible Changed From-To: roger->freebsd-bugs Assignee is currently away from doing FreeBSD work at the moment, so at his request, return this one to the pool. A commit references this bug: Author: jpaetzel Date: Tue Jun 27 03:57:31 UTC 2017 New revision: 320394 URL: https://svnweb.freebsd.org/changeset/base/320394 Log: ioctl METEORGBRIG in bktr_core.c forgets to add 128 to value PR: 59289 Submitted by: Danovitsch@Vitsch.net Changes: head/sys/dev/bktr/bktr_core.c 13 years later...committed, thanks! |
In bktr_core.c the ioctl METEORSBRIG substracts 128 from the given value before storing it in the right brightness register, but METEORGBRIG doesn't add 128 to the value it gets out of the register. Fix: The following patch is agains -CURRENT and simply adds +128 to the value that's read from the register. How-To-Repeat: wantedvalue=129; ioctl(bktr,METEORSBRIG,&wantedvalue); ioctl(bktr,METEORGBRIG,&returnedvalue); if (returnedvalue!=wantedvalue) printf("EEK!\n");