Bug 60107

Lukas Ertl <l.ertl@univie.ac.at> wrote:
> +#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
> -#include &lt;sys/param.h&gt;  /* defines used in kernel.h */

hi lukas!

it is a good idea to have a look at the diff-generated patch
before sending in, to avoid bogus lines like this.

for example when you move a line(i.e. remove & insert at another
place), you get such behaviour in your patch which makes it hard to read.

keep up the good work :)
greets, josef

On Wed, 10 Dec 2003, Josef El-Rayes wrote:

> Lukas Ertl <l.ertl@univie.ac.at> wrote:
> > +#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
> > -#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
>
> hi lukas!
>
> it is a good idea to have a look at the diff-generated patch
> before sending in, to avoid bogus lines like this.

It is a good idea to actually understand what the patch does before
calling it bogus.

The original code had sys/param.h and sys/types.h included, which is a
style(9) violation.  My patch removes one include and moves the other one
further up.

regards,
le

-- 
Lukas Ertl                             eMail: l.ertl@univie.ac.at
UNIX Systemadministrator               Tel.:  (+43 1) 4277-14073
Vienna University Computer Center      Fax.:  (+43 1) 4277-9140
University of Vienna                   http://mailbox.univie.ac.at/~le/

Comment 3 John Baldwin 2003-12-31 18:16:40 UTC

State Changed
From-To: open->closed

Comitted, thanks!