Bug 63272

Summary: possible fix for "marked as broken: unknown LIBTOOL version: ."
Product: Ports & Packages Reporter: Scott Bertilson <scott>
Component: Individual Port(s)Assignee: Ade Lovett <ade>
Status: Closed FIXED    
Severity: Affects Only Me CC: scott
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Scott Bertilson 2004-02-23 16:30:34 UTC
	bsd.port.mk has:
	  BROKEN="unknown LIBTOOL version: ${USE_LIBTOOL_VER}"
	I'm thinking it should say:
	  BROKEN="unknown LIBTOOL version: ${WANT_LIBTOOL_VER}"
	since "USE_LIBTOOL_VER" can be unset when the code
	that generates the "BROKEN" gets executed.  "WANT_LIBTOOL_VER"
	_is_ set and would have the value of "USE_LIBTOOL_VER"
	if the latter had been set, but otherwise has the default.
	This would allow the error to actually show a version
	instead of nothing.

	I would be tempted to go a step farther to change it to:
	  BROKEN="missing LIBTOOL version: devel/libtool${LIBTOOL_VERSION}"
	since that would exactly point to the problem.

Fix: 

See 2 suggestions in "Description" above.
How-To-Repeat: 	I ran into this as a result of a ports tree which
	was not consistently up to date.  Evoke the problem
	by:
	  go into <ports>/devel and hide "libtool*"
	  ("mkdir xx && mv libtool* xx")
	  go into <ports>/x11-fonts/fontconfig and "make"
	"fontconfig" has "USE_LIBTOOL=    yes" without
	specifying "USE_LIBTOOL_VER" which causes
	"WANT_LIBTOOL_VER" to be set, activating the
	code in "bsd.port.mk" while "USE_LIBTOOL_VER"
	remains unset.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-02-24 02:00:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is owned by portmgr.
Comment 2 Kris Kennaway freebsd_committer freebsd_triage 2004-06-06 05:26:13 UTC
Responsible Changed
From-To: portmgr->ade

Assign to libtools maintainer for evaluation
Comment 3 Ade Lovett freebsd_committer freebsd_triage 2004-06-08 18:02:16 UTC
State Changed
From-To: open->feedback

Please see the changes in rev 1.2 of ports/Mk/bsd.autotools.mk. 
I believe this covers your concerns.  Please let me know.
Comment 4 Ade Lovett freebsd_committer freebsd_triage 2004-06-09 20:44:51 UTC
State Changed
From-To: feedback->closed

Submitter happy with the new world order.