Bug 63323

Summary: ports/mail/enigmail - PGPify
Product: Ports & Packages Reporter: jharris
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me CC: jharris
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description jharris 2004-02-25 00:00:33 UTC
	download (and verify) the PGP signature for this port

Fix: -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
NotDashEscaped: You need GnuPG to verify this message

cvs server: Diffing .


iD8DBQFAO+L2SypIl9OdoOMRAhrtAKCfcFgwCE+KEIQ0dJspvphMjbwPtwCgxDnd
+helqHnl9hgTdhBXsRXv8U8=
=uarN
-----END PGP SIGNATURE-------VYTAxmibbYm3Udj8k4W4UTbBoO8bPvVjyAU3rt2ac3QQW4ee
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/enigmail/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	23 Feb 2004 10:34:01 -0000	1.7
+++ Makefile	24 Feb 2004 23:48:46 -0000
@@ -14,6 +14,9 @@
 		${MASTER_SITE_LOCAL}
 MASTER_SITE_SUBDIR=	ale
 DISTFILES=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} \
+		${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}.asc \
+		ipc-1.0.5${EXTRACT_SUFX} ipc-1.0.5${EXTRACT_SUFX}.asc
+EXTRACT_ONLY=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} \
 		ipc-1.0.5${EXTRACT_SUFX}
 
 MAINTAINER=	ale@FreeBSD.org
@@ -22,6 +25,9 @@
 EXTRACT_DEPENDS?=	${WRKDIR}/../../../${LOCAL_SRCDIR}/work/mozilla/Makefile:${PORTSDIR}/${LOCAL_SRCDIR}:configure
 RUN_DEPENDS?=	mozilla:${PORTSDIR}/${LOCAL_SRCDIR}
 
+USE_GPG?=	yes
+SIG_FILES=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}.asc \
+		ipc-1.0.5${EXTRACT_SUFX}.asc
 USE_X_PREFIX=	yes
 USE_GMAKE=	yes
 
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/mail/enigmail/distinfo,v
retrieving revision 1.4
diff -u -r1.4 distinfo
--- distinfo	15 Feb 2004 00:42:25 -0000	1.4
+++ distinfo	24 Feb 2004 23:48:47 -0000
@@ -2,3 +2,5 @@
 SIZE (enigmail-0.83.3.tar.gz) = 325747
 MD5 (ipc-1.0.5.tar.gz) = 457f8277b12f3e37defa71dc186f83b4
 SIZE (ipc-1.0.5.tar.gz) = 137083
+MD5 (enigmail-0.83.3.tar.gz.asc) = a61433732dcd54a33e615e2114209d26
+MD5 (ipc-1.0.5.tar.gz.asc) = bc2032321c6415b407cf2e10d4c5a506
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
How-To-Repeat: 
	apply patch below
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-02-25 06:08:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer.
Comment 2 Alex Dupre freebsd_committer freebsd_triage 2004-02-25 07:58:39 UTC
State Changed
From-To: open->closed

There is no support for USE_GPG in bsd.port.mk yet.
Comment 3 Oliver Eikemeier 2004-02-25 15:22:49 UTC
Jason Harris wrote:

>>Description:
> 
> 	download (and verify) the PGP signature for this port
> 
[...]
>  DISTFILES=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} \
> +		${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}.asc \
> +		ipc-1.0.5${EXTRACT_SUFX} ipc-1.0.5${EXTRACT_SUFX}.asc
> +EXTRACT_ONLY=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} \
>  		ipc-1.0.5${EXTRACT_SUFX}
>  
>  MAINTAINER=	ale@FreeBSD.org
> @@ -22,6 +25,9 @@
>  EXTRACT_DEPENDS?=	${WRKDIR}/../../../${LOCAL_SRCDIR}/work/mozilla/Makefile:${PORTSDIR}/${LOCAL_SRCDIR}:configure
>  RUN_DEPENDS?=	mozilla:${PORTSDIR}/${LOCAL_SRCDIR}
>  
> +USE_GPG?=	yes
> +SIG_FILES=	${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}.asc \
> +		ipc-1.0.5${EXTRACT_SUFX}.asc

From a first glace at PR 60558 I would guess that simply using SIG_SUFFIX=".asc"
would be a better solution.

Anyway, I recommend against applying this patch before PR 60558 or something similar
is tested. We haven't decided on the final structure of PGP support, so this patch
might simply not work at all or worse interfer with what is finally decided on, making
fixes on all interfering ports necessary.

Oliver