Bug 64291

The man page for inet_ntoa does not mention that is uses a static buffer.  It is perhaps worth mentioning this as further calls to inet_ntoa will overwrite the previous response.

Perhaps this should be obvious, however I just fell foul of this and thought clarification on the man page might be useful.

Fix: 

Ammendment to the man page.  If it helps I found this version on a linux machines manpage:

The inet_ntoa() function converts the Internet host address  in  given  in  network byte  order  to  a  string  in  standard  numbers-and-dots notation.  The string is returned in a statically allocated buffer, which subsequent calls will overwrite.
How-To-Repeat: The following section of code (where ip_hdr is a struct *ip) will log both addresses to be the same when they are not.  Presumably because both inet_ntoa's are evaluated before the log function is run.  As a result the first result has been lost.

log(LOG_INFO, "%s -> %s", inet_ntoa(ip_hdr->ip_src), inet_ntoa(ip_hdr->ip_dst));