Bug 64885

Summary: multimedia/mpeg4ip does not compile on amd64
Product: Ports & Packages Reporter: Tim J. Robbins <tim>
Component: Individual Port(s)Assignee: Michael Johnson <ahze>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Tim J. Robbins 2004-03-29 10:40:15 UTC
multimedia/mpeg4ip does not build on 5.2-current/amd64:

cc -DHAVE_CONFIG_H -I. -I. -I. -I/usr/local/include -DDEBUG -O -pipe -W -Wall -Wwrite-strings -Wbad-function-cast -Wmissing-prototypes -Wmissing-declarations -c inet_ntop.c -MT inet_ntop.lo -MD -MP -MF .deps/inet_ntop.TPlo  -fPIC -DPIC -o .libs/inet_ntop.lo
inet_ntop.c: In function `__inet_ntop':
inet_ntop.c:53: error: argument `size' doesn't match prototype
/usr/include/arpa/inet.h:143: error: prototype declaration
gmake[5]: *** [inet_ntop.lo] Error 1
gmake[5]: Leaving directory `/usr/ports/multimedia/mpeg4ip/work/mpeg4ip-0.9.9/lib/rtp'

Fix: 

Not provided.
How-To-Repeat: Try to build multimedia/mpeg4ip on 5.2-current/amd64.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2004-03-29 14:50:43 UTC
State Changed
From-To: open->analyzed

Over to Maintainer. 

A patch for this problem can be found here: 
http://people.freebsd.org/~arved/stuff/patch-lib::rtp::inet_ntop.c 

But the build fails later with:  

cc -shared  mpeg4_audio_config.lo mpeg4_sdp.lo -Wl,--whole-archive ../../../lib/bitstream/.libs/libbitstream.a -Wl,--no-whole-archive  -L/usr/local/lib ../../../lib/bitstream/.libs/libbitstream.a -lpthread  -lc  -Wl,-soname -Wl,libmp4util.so.0 -o .libs/libmp4util.so.0 
/usr/bin/ld: ../../../lib/bitstream/.libs/libbitstream.a(bitstream.o): relocation R_X86_64_32S can not be used when making a shared object; recompile with -fPIC 



Comment 2 Tilman Keskinoz freebsd_committer freebsd_triage 2004-03-29 14:50:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lioux
Comment 3 Tim Robbins freebsd_committer freebsd_triage 2004-06-17 15:06:51 UTC
Responsible Changed
From-To: lioux->freebsd-ports-bugs

Unassign this PR; lioux is clearly not interested in maintaining 
the mpeg4ip port.
Comment 4 Tim Robbins freebsd_committer freebsd_triage 2004-06-17 15:31:04 UTC
On Thu, Jun 17, 2004 at 02:08:19PM +0000, Tim J. Robbins wrote:
> Synopsis: multimedia/mpeg4ip does not compile on amd64

Here is a (fairly crude) patch that makes it compile and mostly work
on amd64:

--- Makefile.old	Fri Jun 18 00:14:12 2004
+++ Makefile	Fri Jun 18 00:15:02 2004
@@ -121,6 +121,8 @@
 	@${REINPLACE_CMD} -e 's|use_mpeg4ip_xvid=false|use_mpeg4ip_xvid=true|g' \
 		-e 's|#define HAVE_XVID_H 1||g'	\
 		${WRKSRC}/configure
+# Remove bogus -static flags
+	@${FIND} . -name Makefile.in -exec ${GREP} -q 'la_LDFLAGS.*=.*-static' {} \; -exec ${REINPLACE_CMD} '/la_LDFLAGS.*=.*-static/d' {} \;
 
 .if ${ARCH} != "i386"
 # emms opcode should be noop in non-i386 non-MMX ARCH
Comment 5 Tim Robbins freebsd_committer freebsd_triage 2004-06-30 05:04:00 UTC
It looks like the amd64 problems may be fixed in mpeg4ip 1.1. Please update
the port.
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2004-07-17 21:34:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lioux

Over to maintainer.
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2004-07-19 08:13:38 UTC
State Changed
From-To: analyzed->closed

Should be fixed with commit of 2004-07-18 17:59:33 UTC.
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2004-07-19 08:50:21 UTC
State Changed
From-To: closed->open

Mea culpa.  kris has noted in his followup to ports/69043, which I 
mistakenly assumed would fix the problem, that the fix in this PR is 
the preferred one and the fix in 69043 is questionable.  This was my 
mistake and I apologize.
Comment 9 Mario Sergio Fujikawa Ferreira freebsd_committer freebsd_triage 2005-03-10 03:04:34 UTC
Responsible Changed
From-To: lioux->ahze

Over to maintainer
Comment 10 Michael Johnson freebsd_committer freebsd_triage 2005-03-11 08:56:23 UTC
State Changed
From-To: open->feedback

Is this still a problem on amd64 ?
Comment 11 Michael Johnson freebsd_committer freebsd_triage 2005-03-14 19:53:31 UTC
State Changed
From-To: feedback->closed

This shuold be fixed with 1.1.