Bug 65403

Summary: [lang/php4] Fix php4 build with curl 7.11.1
Product: Ports & Packages Reporter: Sunpoet Po-Chuan Hsieh <sunpoet>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Sunpoet Po-Chuan Hsieh 2004-04-10 19:30:19 UTC
After upgrading curl from 7.10.0 to 7.11.1, building php4 failed for two changes:
1. HttpPost -> curl_httppost
2. CURLOPT_PASSWDFUNCTION is defined as 0 (same as CURLOPT_MUTE)
Compilation passed after patching ext/curl/curl.c.

Note: this patch works for curl 7.11.1 only.

Fix: % diff -u ext/curl/curl.c.orig ext/curl/curl.c
How-To-Repeat: 
% pkg_info -Ix curl
curl-7.11.1         Non-interactive tool to get files from FTP, GOPHER, HTTP(S)
% cd /usr/ports/lang/php4
% make
===>  Building for php4-4.3.5_7
/bin/sh /usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/libtool --silent --preserve-dup-deps --mode=compile gcc  -Iext/curl/ -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/ -DPHP_ATOM_INC -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/include -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/main -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5 -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/Zend -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include/freetype2 -I/usr/local/include/c-client -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/mbstring/mbregex -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/mbstring/libmbfl -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/mbstring/libmbfl/mbfl -I/usr/local/include/mysql  -I/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/TSRM  -O2 -pipe -s -march=pentium4  -prefer-pic -c /usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c -o ext
 /curl/curl.lo
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c: In function `curl_free_post':
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:568: warning: passing arg 1 of `curl_formfree' from incompatible pointer type
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c: In function `alloc_curl_handle':
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:608: error: invalid application of `sizeof' to an incomplete type
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c: In function `zif_curl_setopt':
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:845: error: duplicate case value
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:700: error: previously used here
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:890: warning: passing arg 1 of `curl_formadd' from incompatible pointer type
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:890: warning: passing arg 2 of `curl_formadd' from incompatible pointer type
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:898: warning: passing arg 1 of `curl_formadd' from incompatible pointer type
/usr/ports/works/usr/ports/lang/php4/work/php-4.3.5/ext/curl/curl.c:898: warning: passing arg 2 of `curl_formadd' from incompatible pointer type
*** Error code 1

Stop in /usr/ports/works/usr/ports/lang/php4/work/php-4.3.5.
*** Error code 1

Stop in /usr/ports/lang/php4.
*** Error code 1

Stop in /usr/ports/lang/php4.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2004-04-10 19:42:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ale


To PHP maintainer.
Comment 2 Alex Dupre freebsd_committer freebsd_triage 2004-04-16 08:52:11 UTC
State Changed
From-To: open->closed

Fixed with the new php release.