Bug 65900

Summary: (non-maintainer) IGNORE p5-ExtUtils-MakeMaker for Perl >= 5.6
Product: Ports & Packages Reporter: Trevor Johnson <trevor>
Component: Individual Port(s)Assignee: freebsd-perl (Nobody) <perl>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Trevor Johnson freebsd_committer freebsd_triage 2004-04-23 00:00:46 UTC
	As noted by des@, MakeMaker is included in recent versions of Perl.

How-To-Repeat: 	N/A
Comment 1 Trevor Johnson freebsd_committer freebsd_triage 2004-04-23 00:04:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

for 4.10 freeze
Comment 2 Michael Johnson 2004-04-23 00:26:49 UTC
I approve this patch, Thanks!
Comment 3 Anton Berezin 2004-04-23 08:00:17 UTC
On Thu, Apr 22, 2004 at 03:50:27PM -0700, Trevor Johnson wrote:
> 
> >Number:         65900
> >Category:       ports
> >Synopsis:       (non-maintainer) IGNORE p5-ExtUtils-MakeMaker for Perl >= 5.6
> >Confidential:   no
> >Severity:       serious
> >Priority:       medium
> >Responsible:    freebsd-ports-bugs
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          change-request
> >Submitter-Id:   current-users
> >Arrival-Date:   Thu Apr 22 16:00:46 PDT 2004
> >Closed-Date:
> >Last-Modified:
> >Originator:     Trevor Johnson
> >Release:        
> >Organization:
> >Environment:
> >Description:
> 	As noted by des@, MakeMaker is included in recent versions of Perl.

MakeMaker is included in _all_ versions of Perl FreeBSD cares about.
The proper criterium should be the version of the module as a separate
port vs. the version of the module supplied with Perl.

\Anton.
-- 
Floating point will almost always have enough precision for the task at
hand, and by the time it doesn't, it will. :-)  -- Larry Wall
Comment 4 Trevor Johnson 2004-04-24 09:48:39 UTC
Anton Berezin wrote:

> MakeMaker is included in _all_ versions of Perl FreeBSD cares about.
> The proper criterium should be the version of the module as a separate
> port vs. the version of the module supplied with Perl.

What would you recommend, specifically?
-- 
Trevor Johnson
Comment 5 Anton Berezin 2004-04-24 13:29:03 UTC
On Sat, Apr 24, 2004 at 04:48:39AM -0400, Trevor Johnson wrote:
> Anton Berezin wrote:
> 
> > MakeMaker is included in _all_ versions of Perl FreeBSD cares about.
> > The proper criterium should be the version of the module as a separate
> > port vs. the version of the module supplied with Perl.
> 
> What would you recommend, specifically?

If the module version is the same or more recent than the one supplied
in 5.005_03, 5.6.X, 5.8.X, do not IGNORE the port.  If this is not the
case, IGNORE the port for specific perl versions, but be careful during
port updates, so that such IGNOREs do not become stale.  Also watch for
perl ports updates, but this is less likely to become a problem.

We have 6.21 in the ports.  5.005_03 has 5.4302.  5.6.1 has 5.45.  5.8.2
currently has 6.17.  Hence, no IGNOREs.

\Anton.
-- 
Floating point will almost always have enough precision for the task at
hand, and by the time it doesn't, it will. :-)  -- Larry Wall
Comment 6 Kris Kennaway 2004-04-24 13:34:52 UTC
On Sat, Apr 24, 2004 at 05:30:20AM -0700, Anton Berezin wrote:
> The following reply was made to PR ports/65900; it has been noted by GNATS.
> 
> From: Anton Berezin <tobez@tobez.org>
> To: Trevor Johnson <trevor@jpj.net>
> Cc: ahze@ahze.net, FreeBSD-gnats-submit@FreeBSD.org
> Subject: Re: ports/65900: (non-maintainer) IGNORE p5-ExtUtils-MakeMaker for Perl >= 5.6
> Date: Sat, 24 Apr 2004 14:29:03 +0200
> 
>  On Sat, Apr 24, 2004 at 04:48:39AM -0400, Trevor Johnson wrote:
>  > Anton Berezin wrote:
>  > 
>  > > MakeMaker is included in _all_ versions of Perl FreeBSD cares about.
>  > > The proper criterium should be the version of the module as a separate
>  > > port vs. the version of the module supplied with Perl.
>  > 
>  > What would you recommend, specifically?
>  
>  If the module version is the same or more recent than the one supplied
>  in 5.005_03, 5.6.X, 5.8.X, do not IGNORE the port.  If this is not the
>  case, IGNORE the port for specific perl versions, but be careful during
>  port updates, so that such IGNOREs do not become stale.  Also watch for
>  perl ports updates, but this is less likely to become a problem.
>  
>  We have 6.21 in the ports.  5.005_03 has 5.4302.  5.6.1 has 5.45.  5.8.2
>  currently has 6.17.  Hence, no IGNOREs.

If the port overwrites part of the perl port, it must somehow restore
those files when it is deinstalled, or the perl installation will be
left nonfunctional (and this will eventually become an error on
bento).

Kris
Comment 7 Anton Berezin 2004-04-24 13:45:57 UTC
On Sat, Apr 24, 2004 at 05:34:52AM -0700, Kris Kennaway wrote:
> On Sat, Apr 24, 2004 at 05:30:20AM -0700, Anton Berezin wrote:
> > The following reply was made to PR ports/65900; it has been noted by GNATS.
> > 
> > From: Anton Berezin <tobez@tobez.org>
> > To: Trevor Johnson <trevor@jpj.net>
> > Cc: ahze@ahze.net, FreeBSD-gnats-submit@FreeBSD.org
> > Subject: Re: ports/65900: (non-maintainer) IGNORE p5-ExtUtils-MakeMaker for Perl >= 5.6
> > Date: Sat, 24 Apr 2004 14:29:03 +0200
> > 
> >  On Sat, Apr 24, 2004 at 04:48:39AM -0400, Trevor Johnson wrote:
> >  > Anton Berezin wrote:
> >  > 
> >  > > MakeMaker is included in _all_ versions of Perl FreeBSD cares about.
> >  > > The proper criterium should be the version of the module as a separate
> >  > > port vs. the version of the module supplied with Perl.
> >  > 
> >  > What would you recommend, specifically?
> >  
> >  If the module version is the same or more recent than the one supplied
> >  in 5.005_03, 5.6.X, 5.8.X, do not IGNORE the port.  If this is not the
> >  case, IGNORE the port for specific perl versions, but be careful during
> >  port updates, so that such IGNOREs do not become stale.  Also watch for
> >  perl ports updates, but this is less likely to become a problem.
> >  
> >  We have 6.21 in the ports.  5.005_03 has 5.4302.  5.6.1 has 5.45.  5.8.2
> >  currently has 6.17.  Hence, no IGNOREs.
> 
> If the port overwrites part of the perl port, it must somehow restore
> those files when it is deinstalled, or the perl installation will be
> left nonfunctional (and this will eventually become an error on
> bento).

CONFIGURE_ARGS= INSTALLDIRS=site

in the port's Makefile makes sure it does not happen.

\Anton.
-- 
Floating point will almost always have enough precision for the task at
hand, and by the time it doesn't, it will. :-)  -- Larry Wall
Comment 8 Kris Kennaway 2004-04-24 13:52:45 UTC
On Sat, Apr 24, 2004 at 02:45:57PM +0200, Anton Berezin wrote:

> > If the port overwrites part of the perl port, it must somehow restore
> > those files when it is deinstalled, or the perl installation will be
> > left nonfunctional (and this will eventually become an error on
> > bento).
> 
> CONFIGURE_ARGS= INSTALLDIRS=site
> 
> in the port's Makefile makes sure it does not happen.


Great!

Kris
Comment 9 Kris Kennaway freebsd_committer freebsd_triage 2004-05-19 05:37:28 UTC
Responsible Changed
From-To: portmgr->trevor

Ports freeze is over
Comment 10 Mark Linimon freebsd_committer freebsd_triage 2004-09-03 00:45:29 UTC
State Changed
From-To: open->feedback

To maintainer: do you approve of this change?
Comment 11 Mark Linimon freebsd_committer freebsd_triage 2004-12-13 01:50:06 UTC
State Changed
From-To: feedback->open

Previous maintainer had approved the change, but no longer maintains the 
port.  Note: there was other, subsequent, discussion, so I cannot easily 
tell what the resolution of this PR should be.
Comment 12 Trevor Johnson freebsd_committer freebsd_triage 2005-01-21 22:09:49 UTC
Responsible Changed
From-To: trevor->perl

over to the new maintainers of this port, who probably have far 
more clue about it than I
Comment 13 Trevor Johnson 2005-01-21 23:02:30 UTC
I thought I needed this module for another port that I was working on at
the time.  When I was told that it was already available in "all versions
of Perl that FreeBSD cares about" I wondered whether I had been mistaken
in adding it.  It's been updated a couple of times since but I still
wonder.  Maybe the version in this port has enhancements beyond the
versions included in the main Perl port or base system Perl that make it
worthwhile?
-- 
Trevor Johnson
Comment 14 Anton Berezin freebsd_committer freebsd_triage 2005-09-12 12:42:21 UTC
State Changed
From-To: open->closed

It would seem that the conclusion would be: 

- yes, we want this port in the ports collection; 
- no, we don't want to IGNORE it. 

Hence, this is a NOOP PR.