Bug 65926

Summary: Allow to use only numbers in PORTREVISION/PORTEPOCH
Product: Ports & Packages Reporter: Kirill Ponomarev <krion>
Component: Individual Port(s)Assignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Kirill Ponomarev freebsd_committer freebsd_triage 2004-04-24 06:40:13 UTC 
We have at the moment the scenario that any characters are
allowed in PORTREVISION/PORTEPOCH
   
"Porters Handbook" doesn't also tell about this behaviour.  
Since using numbers in PORTREVISION/PORTEPOCH is a common way
in ports, I'd suggest this patch.
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-04-24 06:40:56 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

portmgr stuff
Comment 2 Oliver Eikemeier 2004-04-24 11:11:25 UTC 
Kirill Ponomarew wrote:

>>Description:
> 
> We have at the moment the scenario that any characters are
> allowed in PORTREVISION/PORTEPOCH
>    
> "Porters Handbook" doesn't also tell about this behaviour.  
> Since using numbers in PORTREVISION/PORTEPOCH is a common way
> in ports, I'd suggest this patch.

Since this no problem in the current ports tree and not very likely
to become one, it would be better to check this in portlint.

> -PORTREVISION?=	0
> +.if defined(PORTREVISION)
>  .if ${PORTREVISION} != 0
> +.if ${PORTREVISION:M*[0-9]*}x !=x
>  _SUF1=	_${PORTREVISION}
> +.else
> +BROKEN=			"PORTREVISION should contain only numbers."
> +.endif
> +.endif
>  .endif

What is the problem with `PORTREVISION?=0'? Btw, you may want to use
something like ${PORTREVISION::C/[0-9]//g}x == x, since your version
accepts numbers like `1a' happily.

-Oliver
Comment 3 Kris Kennaway 2004-04-24 11:31:38 UTC 
On Sat, Apr 24, 2004 at 03:20:20AM -0700, Oliver Eikemeier wrote:
> The following reply was made to PR ports/65926; it has been noted by GNATS.
> 
> From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
> To: Kirill Ponomarew <krion@FreeBSD.org>
> Cc: FreeBSD-gnats-submit@FreeBSD.org
> Subject: Re: ports/65926: Allow to use only numbers in PORTREVISION/PORTEPOCH
> Date: Sat, 24 Apr 2004 12:11:25 +0200
> 
>  Kirill Ponomarew wrote:
>  
>  >>Description:
>  > 
>  > We have at the moment the scenario that any characters are
>  > allowed in PORTREVISION/PORTEPOCH
>  >    
>  > "Porters Handbook" doesn't also tell about this behaviour.  
>  > Since using numbers in PORTREVISION/PORTEPOCH is a common way
>  > in ports, I'd suggest this patch.
>  
>  Since this no problem in the current ports tree and not very likely
>  to become one, it would be better to check this in portlint.

I tend to agree.  I'm also worried about the impact it would have on
INDEX build times.

Semi-tangentially, I'd like to one day set up a portlint tinderbox
that lists portlint warnings and errors in ports, and monitors for
changes.
 
Kris
Comment 4 Oliver Eikemeier freebsd_committer freebsd_triage 2004-07-25 18:01:18 UTC 
State Changed
From-To: open->closed

Closed until the first port has the bright idea to set PORTREVISION=a