Bug 65966

Summary: [patch] /devel/ecb - update 2.11 -> 2.24
Product: Ports & Packages Reporter: Frank Ruell <stoerte>
Component: Individual Port(s)Assignee: Volker Stolz <vs>
Status: Closed FIXED    
Severity: Affects Only Me CC: dryice
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
ecb-2.11-2.24.patch.tar.gz none

Description Frank Ruell 2004-04-25 21:40:19 UTC 
	- update to the current version
	- make a knob to install also ecb's icons
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-05-13 12:18:15 UTC 
Dear maintainer, please review and either approve or reject this patch.

Regards,
   Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-05-13 12:18:34 UTC 
State Changed
From-To: open->feedback

Forwarded PR to maintainer.
Comment 3 Dryice Liu 2004-05-14 00:27:02 UTC 
Hi Frank,

Thanks for the patch. 

I found you may missed one file when submitting the PR. It won't build
without patching ecb/Makefile. I attached a patch below.

Also could you let us know why you choose to not install icons by
default? I might change this later.

The rest of the patch are OK with me.

Also could any committer take a look at ports/63465 [new port]
devel/cedet: Collection of Emacs Development Environment Tools? ECB
will get a lot of enhancements if build with CEDET.


new file: files/patch-Makefile
======================================================================
--- Makefile.orig	Sat May  8 15:22:25 2004
+++ Makefile	Sat May  8 15:23:57 2004
@@ -46,8 +46,8 @@
 # you want compile ECB with the cedet library then set here the full path
 # to the cedet-installation directory.
 
-#CEDET=
-CEDET=C:/Programme/emacs-21/site-lisp/multi-file-packages/cedet-1.0beta2b
+CEDET=
+# CEDET=C:/Programme/emacs-21/site-lisp/multi-file-packages/cedet-1.0beta2b
 
 # -------- Compiling ECB with the semantic < 2.0 -------------------------
 
======================================================================

-- 
Regards,
Dryice
Comment 4 Frank Ruell 2004-05-14 08:20:36 UTC 
Hi Dryice,

Dryice Liu <dryice@HotPop.com> writes:

> Also could you let us know why you choose to not install icons by
> default? I might change this later.

I don't wanted to change the default behaviour of your port, the icons
were also present in 2.11, so I thought you maybe have a reason for not
including it by default, else I would have made it a WITHOUT_* knob.


cheers
Comment 5 Volker Stolz freebsd_committer freebsd_triage 2004-05-16 13:20:44 UTC 
Any last words? Otherwise I'm going to commit this. The CEDET-variable can 
be more easily handled
by simply setting:
MAKE_ARGS= CEDET=""

Volker
Comment 6 Volker Stolz freebsd_committer freebsd_triage 2004-05-16 13:21:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'm on this.
Comment 7 Dryice Liu 2004-05-18 17:05:43 UTC 
Sorry my ssmtp gateway doesn't work these days.

Please commit this PR. I like the idea of using MAKE_ARGS. This will
make making a new knob about choosing wether to use CEDET easier.


Regards,
Dryice
Comment 8 Volker Stolz freebsd_committer freebsd_triage 2004-05-19 09:31:54 UTC 
State Changed
From-To: feedback->closed

Committed with modifications, thanks!