Summary: | [PATCH] net/javadc: fix build on bento [requires bsd.java.mk patch] | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Hervé Quiroz <herve.quiroz> | ||||||
Component: | java | Assignee: | Greg Lewis <glewis> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | glewis | ||||||
Priority: | Normal | ||||||||
Version: | 5.2.1-RELEASE | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Hervé Quiroz
2004-05-07 08:30:29 UTC
Herve Quiroz wrote: > - added '-bootclasspath ${JAVA_CLASSES}' to the command-line for JAVAC when > jikes is used as a substitute for javac. What is the reason for not putting this into bsd.java.mk? If jikes is installed it will be used to compile a port. And then for a port not to fail it should ether set USE_JIKES=no or add -bootclasspath. -- Yuri Khotyaintsev, PhD Swedish Institute of Space Physics, http://www.cluster.irfu.se/yuri Uppsala (IRF-U) http://ovt.irfu.se Yuri, I'm not sure I get your point here... On Fri, May 07, 2004 at 09:47:10AM +0200, Yuri Khotyaintsev wrote: > Herve Quiroz wrote: > > >- added '-bootclasspath ${JAVA_CLASSES}' to the command-line for JAVAC when > > jikes is used as a substitute for javac. > > What is the reason for not putting this into bsd.java.mk? Well actually I put it in bsd.java.mk. This statement is from the ChangeLog for bsd.java.mk > If jikes is installed it will be used to compile a port. And then for a > port not to fail it should ether set USE_JIKES=no or add -bootclasspath. When nothing is asked by the port, jikes is used if present. This may cause problems as jikes requires -bootclasspath to be set to the location of the standard Java API classes. Provided this is not needed when using the former javac command, and as porter won't know in advance if jikes will be used or not (unless the port explicitely requires or forbids its use by setting USE_JIKES), he won't be able to set -bootclasspath accordingly. That's why I had to add these arguments when "jikes is used [transparently] as a substitute for javac"... Is this what you were asking for or did I misunderstood you ? Herve State Changed From-To: open->feedback Ernst, Greg, have you had a chance to review the change to bsd.java.mk suggested herein? Is this significant enough to need a full bento run once the change is committed? I've replied to Herve with one concern I have. Otherwise the patch looks good. I'm just waiting for his response before committing. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org Responsible Changed From-To: freebsd-java->glewis I'll take this. State Changed From-To: feedback->closed Committed, thanks! |