Bug 66433

Summary: Cannot make package for security/fwbuilder
Product: Ports & Packages Reporter: Jonathan <j.e.drews>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
Makefile.fwbuilder.patch none

Description Jonathan 2004-05-10 00:30:24 UTC
Port: fwbuilder-1.1.2_2 (/usr/ports/security/fwbuilder)

Trying to "make package" for fwbuilder fails.

Fix: Apply the attached patches to fix the problem. The affected ports were 
tested with portlint -Av. The fwbuilder port was tested in accordance
with section 2.4 of the Porters Handbook. No errors were found from his
test. Portlint detected spaces instead of tabs and this was fixed.
Subsequent portlint runs only yield minor warnings.

--=-Ey0j0v9fuqMYb1NDW2XM
Content-Disposition: attachment; filename=Makefile.fwbuilder.patch
Content-Type: text/x-patch; name=Makefile.fwbuilder.patch; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

--=-Ey0j0v9fuqMYb1NDW2XM
Content-Disposition: attachment; filename=Makefile.libfwbuilder.patch
Content-Type: text/x-patch; name=Makefile.libfwbuilder.patch; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit



--=-Ey0j0v9fuqMYb1NDW2XM----CLN2qir5Sr5uwsHA0Hgzpo1rm7eUglHJgutb7AXJsQAWXSBk
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile	Sun May  9 11:31:26 2004
+++ /home/xfce/Makefile.fwbuilder.original	Thu May  6 19:52:30 2004
@@ -22,14 +22,14 @@
 USE_GNOME=	glib12 gtk12
 USE_GMAKE=	yes
 USE_LIBTOOL_VER=13
-GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
+GNU_CONFIGURE=  yes
+CONFIGURE_ENV=  CPPFLAGS="-I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib"
 CONFIGURE_ARGS+=	--with-docdir=${DOCSDIR}
 INSTALLS_SHLIB=	yes
 PLIST_SUB+=	PORTVERSION="${PORTVERSION}"
 
-MAN1=		fwbuilder.1 fwblookup.1 fwbedit.1 fwb_ipt.1 fwb_ipf.1 fwb_ipfw.1 fwb_pf.1 \
+MAN1=           fwbuilder.1 fwblookup.1 fwbedit.1 fwb_ipt.1 fwb_ipf.1 fwb_ipfw.1 fwb_pf.1 \
 		fwb_install.1 fwb_compile_all.1
 
 .include <bsd.port.mk>
How-To-Repeat: After installing the port, do a package make. The folloing message
appears:
pkg_add:  could not find package openssl-0.9.7 !
Comment 1 Jonathan 2004-05-10 00:37:29 UTC
Hearty thanks to Chuck Swiger for suggesting this fix.
Comment 2 Jonathan 2004-05-10 00:49:29 UTC
Oops  -- The patch for fwbuilders make file is reversed. Here is the 
correct one.   Sorry about that.

 
Comment 3 j.e.drews 2004-05-10 03:25:20 UTC
I just rebooted the laptop thatbthis fwbuilder was on and upon doing pkgdb -F the fwbuilder port needed to find openssl-0.9.7. 

 This patch is not sufficient. It probably requires an ammended pkg-plist.  Please do not commit it yet.
Comment 4 Jonathan 2004-05-11 00:54:54 UTC
I retested this (on CURRENT) and it does indeed work with the two
patches:

--- /home/xfce/Makefile.libfwbuilder.original	Sun May  9 00:55:31 2004
+++ Makefile	Sun May  9 10:56:48 2004
@@ -16,15 +16,15 @@

--- /home/xfce/Makefile.fwbuilder.original	Sat May  8 14:11:34 2004
 +++ Makefile	Sun May  9 18:45:47 2004

Ignore the very first patch. That one is reversed (pointy hat for me!)

The patches were retested again using 2.4, namely:

     1. make install
        
     2. make package
        
     3. make deinstall
        
     4. pkg_add package-name
        
     5. make deinstall
        
     6. make reinstall
        
     7. make package
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2004-05-25 20:28:31 UTC
State Changed
From-To: open->closed

Committed, thanks!