Bug 68196
| Summary: | [New Port]: linux-zsnes - Linux binary version of ZSNES to fix performance issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Travis Poppe <tlp> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Travis Poppe
2004-06-22 13:20:18 UTC
It was indeed late. :-) portlint -a complains about using cpio directly. It also states that EXTRACT_DEPENDS should appear earlier. I moved this and now it complains that RUN_DEPENDS should appear earlier. Huh? It also mentions possible usage of /usr/X11, this is false and can be ignored. Anyway, with all that said and done, I noticed a problem. This port attempts to compress the manual page it installs (which is already compressed). I quickly read through the bsd port mk file and found some knobs to enable/disable man page compression. I've never used them before and assume the person to commit this will be able to add it in quite easily. I didn't want to submit an entirely new shar archive as a Followup but felt these issues should be mentioned. If a new shar is requested, I'll do my best to re-submit one. -Travis Poppe I decided to re-shar a fixed linux-zsnes after all. The below shell archive fixes the mentioned problems in the previous followup. # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # linux-zsnes # linux-zsnes/Makefile # linux-zsnes/distinfo # linux-zsnes/pkg-descr # echo c - linux-zsnes mkdir -p linux-zsnes > /dev/null 2>&1 echo x - linux-zsnes/Makefile sed 's/^X//' >linux-zsnes/Makefile << 'END-of-linux-zsnes/Makefile' X# New ports collection makefile for: linux-zsnes X# Date created: 22 June 2004 X# Whom: Travis Poppe <tlp@liquidx.org> X# X# $FreeBSD$ X# X XPORTNAME= zsnes XPORTVERSION= 1.36 XCATEGORIES= emulators linux XMASTER_SITES= http://newrpms.sunsite.dk/apt/redhat/en/i386/9.0/RPMS.newrpms/ XPKGNAMEPREFIX= linux- XDISTNAME= ${PORTNAME}-${PORTVERSION}-3.i386 XEXTRACT_SUFX= .rpm XEXTRACT_ONLY= X XMAINTAINER= tlp@liquidx.org XCOMMENT= Linux binary version of the x86 only SNES emulator X XEXTRACT_DEPENDS= rpm2cpio.pl:${PORTSDIR}/archivers/rpm2cpio XRUN_DEPENDS= ${LINUXBASE}/lib/libc-2.3.2.so:${PORTSDIR}/emulators/linux_base-8 \ X ${LINUXBASE}/usr/X11R6/lib/libXi.so.6:${PORTSDIR}/x11/linux-XFree86-libs \ X ${LINUXBASE}/usr/X11R6/lib/libGL.so.1:${PORTSDIR}/graphics/linux_dri \ X ${LINUXBASE}/usr/lib/libpng12.so.0:${PORTSDIR}/graphics/linux-png \ X ${LINUXBASE}/usr/lib/libSDL-1.2.so.0:${PORTSDIR}/devel/linux-sdl12 X XONLY_FOR_ARCHS= i386 XDIST_SUBDIR= rpm XNO_BUILD= yes X XMANCOMPRESSED= yes XMAN1= linux-zsnes.1 XPLIST_FILES= bin/linux-zsnes X XSTRIP= X Xpost-extract: X cd ${WRKDIR}; rpm2cpio.pl ${DISTDIR}/${DIST_SUBDIR}/${DISTNAME}${EXTRACT_SUFX} | ${CPIO} -id --quiet X Xdo-install: X ${INSTALL_MAN} ${WRKDIR}/usr/share/man/man1/zsnes.1.gz ${PREFIX}/man/man1/linux-zsnes.1.gz X ${INSTALL_PROGRAM} ${WRKDIR}/usr/bin/zsnes ${PREFIX}/bin/linux-zsnes X X.include <bsd.port.mk> END-of-linux-zsnes/Makefile echo x - linux-zsnes/distinfo sed 's/^X//' >linux-zsnes/distinfo << 'END-of-linux-zsnes/distinfo' XMD5 (rpm/zsnes-1.36-3.i386.rpm) = 9c83fe09286477839cc428c3857b8086 XSIZE (rpm/zsnes-1.36-3.i386.rpm) = 474922 END-of-linux-zsnes/distinfo echo x - linux-zsnes/pkg-descr sed 's/^X//' >linux-zsnes/pkg-descr << 'END-of-linux-zsnes/pkg-descr' XAn x86 only Super Nintendo Entertainment System (SNES) Emulator, Xwith higher compatibility rates than snes9x. X XThis is the Linux binary version. X XNote: This port exists due to performance issues (sound) with our native Xversion that remain unfixed. When these issues are fixed, this port should Xbe removed. X XWWW: http://www.zsnes.com/ X X- Travis Poppe Xtlp@liquidx.org END-of-linux-zsnes/pkg-descr exit Can someone please let me know what's going on with this port? I submitted it over a month ago and it still has not yet been committed. Just to note that the ZSNES patch that was committed a week or so ago (submitted by me) to our native version does NOT fix all sound performance issues. This port has -zero- problems as far as performance goes, which is why it exists. As the pkg-descr suggests, this port should be removed when (if) our native version can ever match the performance of the Linux binary. Travis Poppe tlp State Changed From-To: open->closed Committed, thanks! |
