Bug 68568

Summary: bsd.autotools.mk should not use `.error'
Product: Ports & Packages Reporter: Oliver Eikemeier <eikemeier>
Component: Individual Port(s)Assignee: Ade Lovett <ade>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Oliver Eikemeier 2004-07-01 21:30:31 UTC
bsd.autotools.mk uses `.error' in multiple places:

  135:. error USE_${i} deprecated: replace with USE_${i}_VER=...
  138:. error WANT_${i} deprecated: replace with WANT_${i}_VER=...
  165:. error Unknown AUTOMAKE version: ${WANT_AUTOMAKE_VER}
  210:.error Incompatible autoheader ${USE_AUTOHEADER_VER} and autoconf ${USE_AUTOCONF_VER}
  215:.error Incompatible autoheader ${WANT_AUTOHEADER_VER} and autoconf ${WANT_AUTOCONF_VER}
  232:. error Unknown AUTOCONF version: ${WANT_AUTOCONF_VER}
  282:. error Unknown LIBTOOL version: ${WANT_LIBTOOL_VER}

This has the ill effect that a misconfigured port breaks all port tools,
like INDEX building, pkg_version, portupgrade, chkversion and others.

I assume that tools that should report these misconfigurations, like
portsmon, are affected too.

Most port tools use make -V to extract information fro the ports,
so FreshPorts can do make -VPKGNAME -VBROKEN and could display that
port PKGNAME is broken because BROKEN.

Common practice in the ports tree is to set BROKEN in this case.

Fix: 

Replace `.error' with `BROKEN='
Comment 1 Oliver Eikemeier freebsd_committer freebsd_triage 2004-07-01 21:31:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ade

Over to maintainer.
Comment 2 Ade Lovett freebsd_committer freebsd_triage 2004-07-01 22:13:17 UTC
State Changed
From-To: open->closed

Done.