Bug 68994

Summary: Fix Dependency: devel/p5-VCP doesn't need File::Temp
Product: Ports & Packages Reporter: Rong-En Fan <rafan>
Component: Individual Port(s)Assignee: Hiroki Sato <hrs>
Status: Closed FIXED    
Severity: Affects Only Me CC: hrs
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Rong-En Fan 2004-07-13 16:10:19 UTC 
	Since VCP need perl >= 5.6 which has File::Temp as built-in
	module, we don't need this.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-07-14 12:52:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->hrs

Over to maintainer.
Comment 2 Rong-En 2004-07-18 15:59:22 UTC 
This following patch is more correctly since
File::Temp is included in Perl >= 5.6.1.

diff -ruN p5-VCP.orig/Makefile p5-VCP/Makefile
--- p5-VCP.orig/Makefile	Thu Jul 15 01:35:33 2004
+++ p5-VCP/Makefile	Sun Jul 18 22:57:10 2004
@@ -21,7 +21,6 @@
 		${SITE_PERL}/IPC/Run3.pm:${PORTSDIR}/devel/p5-IPC-Run3 \
 		${SITE_PERL}/Pod/Links.pm:${PORTSDIR}/www/p5-PodToHTML \
 		${SITE_PERL}/${PERL_ARCH}/Digest/MD5.pm:${PORTSDIR}/security/p5-Digest-MD5 \
-		${SITE_PERL}/File/Temp.pm:${PORTSDIR}/devel/p5-File-Temp \
 		${SITE_PERL}/Regexp/Shellish.pm:${PORTSDIR}/devel/p5-Regexp-Shellish \
 		${SITE_PERL}/BFD.pm:${PORTSDIR}/devel/p5-BFD \
 		${SITE_PERL}/Text/Table.pm:${PORTSDIR}/textproc/p5-Text-Table \
@@ -106,6 +105,11 @@
 
 .if ${PERL_LEVEL} < 500600
 BROKEN=		"Does not compile with perl ${PERL_VERSION}"
+.endif
+
+.if ${PERL_LEVEL} < 500601
+BUILD_DEPENDS+=	${SITE_PERL}/File/Temp.pm:${PORTSDIR}/devel/p5-File-Temp
+RUN_DEPENDS+=	${SITE_PERL}/File/Temp.pm:${PORTSDIR}/devel/p5-File-Temp
 .endif
 
 .include <bsd.port.post.mk>
Comment 3 Rong-En Fan 2004-08-15 15:06:11 UTC 
This is already fixed by mat@ in Rev 1.4:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/p5-VCP/Makefile.diff?r1=1.3&r2=1.4&f=h

Please close this pr.
Comment 4 Vanilla I. Shu freebsd_committer freebsd_triage 2004-08-16 12:01:02 UTC 
State Changed
From-To: open->closed

Closed by submitter's request (via email & irc).