Bug 69268

Summary:	[patch] Fix ndiscvt(8) to warn you if it's going to generate a useless module
Product:	Base System	Reporter:	Daniel O'Connor <darius>
Component:	bin	Assignee:	Andriy Voskoboinyk <avos>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	avos
Priority:	Normal	Keywords:	patch
Version:	5.2-CURRENT	Flags:	avos: mfc-stable12+ avos: mfc-stable11+ avos: mfc-stable10+
Hardware:	Any
OS:	Any

Description Daniel O'Connor 2004-07-19 09:00:49 UTC

Some drivers (eg Intel Wireless 2100) for Windows 2000 cause ndiscvt to generate a driver which doesn't match any hardware. This patch causes it to generate a error in this case.

Fix: 

http://www.gsoft.com.au/~doconnor/ndiscvt-warnonempty.diff
How-To-Repeat: Use the NDIS5 Intel Wireless 2100 drivers with ndiscvt and try and load the resulting kld - it doesn't attach to anything.

Comment 1 le freebsd_committer

2004-07-19 19:04:28 UTC

Responsible Changed
From-To: freebsd-bugs->wpaul

Over to Mr. Evil.

Comment 2 Mark Linimon freebsd_committer

2007-07-31 08:32:55 UTC

Responsible Changed
From-To: wpaul->freebsd-bugs

Reassign from inactive committer. 

Hat:		bugmeister

Comment 3 Eitan Adler freebsd_committer

2017-12-31 07:59:17 UTC

For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped

Comment 4 commit-hook freebsd_committer

2019-01-30 12:33:02 UTC

A commit references this bug:

Author: avos
Date: Wed Jan 30 12:32:47 UTC 2019
New revision: 343576
URL: https://svnweb.freebsd.org/changeset/base/343576

Log:
  ndiscvt(8): abort if no IDs were found during conversion.

  Checked with Broadcom driver mentioned in PR 179285.

  PR:		69268
  Submitted by:	<darius@dons.net.au>
  MFC after:	5 days

Changes:
  head/usr.sbin/ndiscvt/inf.c
  head/usr.sbin/ndiscvt/ndiscvt.c

Comment 5 commit-hook freebsd_committer

2019-02-04 03:44:44 UTC

A commit references this bug:

Author: avos
Date: Mon Feb  4 03:44:08 UTC 2019
New revision: 343730
URL: https://svnweb.freebsd.org/changeset/base/343730

Log:
  MFC r343576:
  ndiscvt(8): abort if no IDs were found during conversion.

  PR:		69268
  Submitted by:	<darius@dons.net.au>

Changes:
_U  stable/10/
  stable/10/usr.sbin/ndiscvt/inf.c
  stable/10/usr.sbin/ndiscvt/ndiscvt.c
_U  stable/11/
  stable/11/usr.sbin/ndiscvt/inf.c
  stable/11/usr.sbin/ndiscvt/ndiscvt.c
_U  stable/12/
  stable/12/usr.sbin/ndiscvt/inf.c
  stable/12/usr.sbin/ndiscvt/ndiscvt.c