Bug 69832
| Summary: | [PATCH] multimedia/transcode: [add jpeg-mmx support] | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Michael Johnson <ahze> | ||||
| Component: | Individual Port(s) | Assignee: | Michael Johnson <ahze> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | hendrik | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Michael Johnson
2004-07-31 00:50:27 UTC
Dear maintainer, please review the proposed patch! Volker State Changed From-To: open->feedback Forwarded PR to maintainer Hi! Volker Stolz wrote: > Dear maintainer, please review the proposed patch! I've just tested it. Works. Thanks, Hendrik -- Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/ drag me, drop me - treat me like an object State Changed From-To: feedback->suspended Suspend until ports/69829 is committed. Hi,
I see a problem with my patch.
in the part that reads
.if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62)
WITH_JPEGMMX= yes
WITH_NASM= yes
.endif
it probably should be the following because you can define WITH_JPEGMMX
and not have nasm installed.
.if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62)
WITH_JPEGMMX= yes
.endif
.if defined(WITH_JPEGMMX)
WITH_NASM= yes
.endif
Michael
Hi! Michael Johnson wrote: > it probably should be the following because you can define WITH_JPEGMMX > and not have nasm installed. JPEGMMX has NASM as build depends and is only for i386. With WITH_JPEGMMX turned on it turns transcode into a i386 only port. WITH_NASM implies ONLY_FOR_ARCHES=i386 so it's been taken care of as of now. You are right about the fact that one can build transcode without having nasm installed but still having WITH_JPEGMMX (probably installed as binary package). Your second part makes sense but I'd add ONLY_FOR_ARCHES= i386: .if exists(${LOCALBASE}/lib/libjpeg-mmx.so.62) WITH_JPEGMMX= yes ONLY_FOR_ARCHES= i386 .endif Hendrik -- Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/ drag me, drop me - treat me like an object Adding to audit trail, from misfiled PR ports/72843: Date: Mon, 18 Oct 2004 22:02:39 +0200 From: Hendrik Scholz <hscholz@raisdorf.net> Message-Id: <4174215F.1030600@raisdorf.net> References: <200410162319.i9GNJYfE066651@blueheron.ahze.net> Hi! Michael Johnson wrote: > make WITH_FFMPEG=yes WITH_OPTIMIZED_CFLAGS=yes I couldn't reproduce the problem. I've compiled transcode on 5.3-BETA7/i386 and even with -O3 it compiled fine. Do you have any additional options in /etc/make.conf? I've tested the patch ... it doesn't harm anything but I never got any reports on similar problems so I'm not sure if it's a general problem. Thanks, Hendrik -- Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/ drag me, drop me - treat me like an object Adding to audit trail, from misfiled PR ports/72846: Date: Mon, 18 Oct 2004 16:18:11 -0400 From: Michael Johnson <ahze@ahze.net> Message-Id: <D53478A5-2142-11D9-9C89-000A958C81C6@ahze.net> References: <200410162319.i9GNJYfE066651@blueheron.ahze.net> <4174215F.1030600@raisdorf.net> Hi Hendrik! After seeing what you wrote I did farther tests and figured out that I built ffmpeg with OUT WITH_OPTIMIZED_CFLAGS defined and transcode with WITH_OPTIMIZED_CFLAGS defined and that seems to be the problem. since this is such a rare case I dont think we need to do anything to transcode at all and just close this pr. Michael Adding to audit trail, from misfiled PR ports/72847: Date: Mon, 18 Oct 2004 16:21:38 -0400 From: Michael Johnson <ahze@ahze.net> Message-Id: <50E04292-2143-11D9-9C89-000A958C81C6@ahze.net> References: <200410162319.i9GNJYfE066651@blueheron.ahze.net> <4174215F.1030600@raisdorf.net> oh, and btw, everything works with the following define WITH_OPTIMIZED_CFLAGS on ffmpeg and transcode or define WITH_OPTIMIZED_CFLAGS on ffmpeg and not transcode but fails with define WITH_OPTIMIZED_CLFAGS on transcode and not ffmpeg Michael Responsible Changed From-To: freebsd-ports-bugs->ahze handle Please see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/69832 do you approve this patch? Michael State Changed From-To: suspended->feedback Asked maintainer for feedback Hi! Yes, approved. Thanks, Hendrik -- Hendrik Scholz - <hscholz@raisdorf.net> - http://www.wormulon.net/ drag me, drop me - treat me like an object State Changed From-To: feedback->closed Committed |
