Bug 70232

Summary: libpng port has bad checksum
Product: Ports & Packages Reporter: Gregory Bond <gnb>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me CC: ache
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Gregory Bond 2004-08-10 00:30:21 UTC 
Libpng port won't build do to checksum failures on the patch files.

Marked as serious/high because a HEAP of stuff depends on this!

[Yes, I've removed the distfiles and refetched, and cvsup'd the port, and 
checked gnats....]

root@grollo[/usr/ports/graphics/png] # make checksum
===>  Vulnerability check disabled

Fix: 

Not sure of the providence of the patch files, but try "make makesum" 
doesn't actually help - the patch files don't apply properly.

===>  Patching for png-1.2.5_8
===>  Applying distribution patches for png-1.2.5_8
2 out of 2 hunks failed--saving rejects to pngrtran.c.rej
*** Error code 2
How-To-Repeat: 	cd /usr/ports/graphics/png && make checksum

$ ls -l /usr/ports/distfiles/libpng-patch00-pngrtran-filler-RRGGBB-overflow.txt
-rw-------  1 root  wheel  1130 Aug  5 00:07 /usr/ports/distfiles/libpng-patch00-pngrtran-filler-RRGGBB-overflow.txt
$ grep RRGGBB distinfo
MD5 (libpng-patch00-pngrtran-filler-RRGGBB-overflow.txt) = 1e49d90ffa33c25b5af90311fe022436
SIZE (libpng-patch00-pngrtran-filler-RRGGBB-overflow.txt) = 1105
$ 

[note different size]
Comment 1 Michael Nottebrock freebsd_committer freebsd_triage 2004-08-10 00:53:43 UTC 
The checksums are correct, however the ftp server the patches are hosted on 
seems to be able to confuse proxies very much. I myself have only been able 
to fetch those files by first deleting them from /usr/ports/distfiles and 
then fetching them directly, bypassing the proxy.

-- 
   ,_,   | Michael Nottebrock               | lofi@freebsd.org
 (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
   \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org
Comment 2 Gregory Bond 2004-08-10 01:56:34 UTC 
lofi@freebsd.org said:
> The checksums are correct, however the ftp server the patches are
> hosted on  seems to be able to confuse proxies very much.

Urk, Michael is right.  I fetched the the patch files using a real FTP client
(not fetch through the squid HTTP proxy) and the checksums come out fine.

OK, lets change this PR to read: "Put the patch files somewhere that is 
proxy-friendly!!!!"

Or close it, perhaps.

Thanks, Michael.
Comment 3 Michael Nottebrock freebsd_committer freebsd_triage 2004-08-10 02:03:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ache

Over to maintainer.
Comment 4 Andrey A. Chernov freebsd_committer freebsd_triage 2004-08-10 07:49:18 UTC 
State Changed
From-To: open->closed

swrinde.nde.swri.edu removed from MASTER_SITES