Bug 70804

Summary: /usr/ports/databases/p5-DBD-mysql50/work/DBD-mysql-2.9004 fails to compile
Product: Ports & Packages Reporter: Bob Melson <melsonr>
Component: Individual Port(s)Assignee: skv <skv>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Bob Melson 2004-08-21 22:30:19 UTC 
 This problem has previously been reported, with no movement evident on the part of the maintainer/developer.  First report saw the problem occurring in 5.2.1, my follow up with 4.10 and now this.  This port has bden broken since first introduction.  The maintainer's suggestion to  find and use a specific mysql.xs module is laughable as the module doesn't exist.  Errors are as follow:


  ===>  Building for p5-DBD-mysql50-2.9004
cc -c  -I/usr/local/lib/perl5/site_perl/5.8.5/mach/auto/DBI -I/usr/local/include/mysql -O -pipe  -D_THREAD_SAFE -DDBD_MYSQL_WITH_SSL  -O -pipe -O -pipe    -DVERSION=\"2.9004\"  -DXS_VERSION=\"2.9004\" -DPIC -fPIC "-I/usr/local/lib/perl5/5.8.5/mach/CORE"   mysql.c
mysql.xs: In function `XS_DBD__mysql__dr__admin_internal':
mysql.xs:103: `SHUTDOWN_DEFAULT' undeclared (first use in this function)
mysql.xs:103: (Each undeclared identifier is reported only once
mysql.xs:103: for each function it appears in.)
mysql.xs:103: too many arguments to function `mysql_shutdown'
*** Error code 1

Stop in /usr/ports/databases/p5-DBD-mysql50/work/DBD-mysql-2.9004.
*** Error code 1

Stop in /usr/ports/databases/p5-DBD-mysql50.

How-To-Repeat: Trying compiling    /usr/ports/databases/p5-DBD-mysql50. on any system.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-08-22 06:47:42 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->skv

Over to maintainer.
Comment 2 Chad Fraleigh 2004-09-07 22:15:35 UTC 
	I don't think anyone has answered this yet, but here goes.. The
problem is that the extra parameter was added with mysql 4.1.3 and 5.0.1,
but not 5.0.0.

	Here is a patch that seems to work:


*** work/DBD-mysql-2.9004/mysql.xs.orig	Mon Jun 28 23:03:15 2004
--- work/DBD-mysql-2.9004/mysql.xs	Tue Sep  7 17:01:09 2004
***************
*** 97,103 ****
         }

         if (strEQ(command, "shutdown")) {
! #if MYSQL_VERSION_ID < 40103
  	   result = mysql_shutdown(sock);
  #else
  	   result = mysql_shutdown(sock, SHUTDOWN_DEFAULT);
--- 97,103 ----
         }

         if (strEQ(command, "shutdown")) {
! #if MYSQL_VERSION_ID < 40103 || MYSQL_VERSION_ID == 50000
  	   result = mysql_shutdown(sock);
  #else
  	   result = mysql_shutdown(sock, SHUTDOWN_DEFAULT);





-Chad
Comment 3 skv freebsd_committer freebsd_triage 2004-10-19 09:48:31 UTC 
State Changed
From-To: open->closed

Committed, thanks.