Bug 70960

Summary: "ndc restart" dumps core when named is running with options
Product: Base System Reporter: SANETO Takanori <sanewo>
Component: binAssignee: Doug Barton <dougb>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.2-CURRENT   
Hardware: Any   
OS: Any   

Description SANETO Takanori 2004-08-26 00:00:36 UTC
      When named is running with options (e.g. "/usr/sbin/named -u bind"), "ndc restart" cause core dump.

Fix: Following patch to ndc.c should fix this. I confirmed that ISC bind-8.4.4 has this fix in it.

retrieving revision 1.1.1.7


static int--qLKfRAgmDc9ZMZVdWkULLUadT4gvCbd4yFKyCLwOuIoJ3XRO
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

diff -u -r1.1.1.7 ndc.c
--- contrib/bind/bin/ndc/ndc.c  17 Jun 2003 08:24:06 -0000      1.1.1.7
+++ contrib/bind/bin/ndc/ndc.c  25 Aug 2004 15:21:23 -0000
@@ -353,6 +353,7 @@
                *tp++ = c;
                cp++;
        }
+       *tp = '\0';
 }
How-To-Repeat:       as described above.
Comment 1 Ceri Davies freebsd_committer freebsd_triage 2004-08-26 00:06:00 UTC
Responsible Changed
From-To: freebsd-bugs->dougb

Assign to our BIND maintainer.
Comment 2 SANETO Takanori 2004-10-09 06:41:26 UTC
As 5.3 will not have ndc (and rndc does not support restart subcommand), I 
think this PR can be closed.
Comment 3 Doug Barton freebsd_committer freebsd_triage 2004-10-18 00:20:17 UTC
State Changed
From-To: open->closed


Originator states that this can be closed.