Bug 71652

Summary: rdr@pf doesnt work properly with fastforwarding
Product: Base System Reporter: Divacky Roman <xdivac02>
Component: kernAssignee: Andre Oppermann <andre>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.3-BETA3   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
FASTFWD_OURS.byteorder.diff none

Description Divacky Roman 2004-09-12 15:40:12 UTC
	The problem reported in bin/71490 was fixed by setting
	net.inet.ip.fastforwarding=0
	ie. by setting it to 1 (enabling it) the rdr doesnt work properly

Fix: 

I am not aware of any.
How-To-Repeat: 
set net.inet.ip.fastforwarding=1 and try to use rdr and/or ftp-proxy
Comment 1 Max Laier 2004-09-13 00:56:42 UTC
This is caused by a superfluous byte order change in ip_fastfwd.c while the 
comment in ip_input.c clearly states what is expected:
    /*
     * ip_fastforward firewall changed dest to local.
     * We expect ip_len and ip_off in host byte order.
     */

Diff attached and on: 
http://people.freebsd.org/~mlaier/FASTFWD_OURS.byteorder.diff

-- 
 Max
Comment 2 mlaier freebsd_committer freebsd_triage 2004-09-13 01:05:07 UTC
Responsible Changed
From-To: freebsd-bugs->andre

Over to Andre for evaluation.
Comment 3 Andre Oppermann freebsd_committer freebsd_triage 2004-09-13 18:02:18 UTC
State Changed
From-To: open->patched

The problem is patched in sys/netinet/ip_fastfwd.c rev. 1.20.
Comment 4 Andre Oppermann freebsd_committer freebsd_triage 2004-09-16 21:37:05 UTC
State Changed
From-To: patched->closed

MFC to RELENG_5 is done.  Case closed.