Bug 71826

Comment 1 Marc Fonvieille 2004-09-17 19:42:45 UTC

On Fri, Sep 17, 2004 at 08:27:45PM +0200, Joel Dahl wrote:
> >Description:
> The attached patch fixes some whitespaces in
> doc/en_US.ISO8859-1/books/handbook/multimedia/chapter.sgml
>

This was often discussed in past (consult the freebsd-doc archives).
With often the same result: when it's not "mandatory", we leave the
things in this state.

Marc

On Fri, 2004-09-17 at 20:42, Marc Fonvieille wrote:
> On Fri, Sep 17, 2004 at 08:27:45PM +0200, Joel Dahl wrote:
> > >Description:
> > The attached patch fixes some whitespaces in
> > doc/en_US.ISO8859-1/books/handbook/multimedia/chapter.sgml
> >
> 
> This was often discussed in past (consult the freebsd-doc archives).
> With often the same result: when it's not "mandatory", we leave the
> things in this state.
> 
> Marc

Hm, yes, I just found a couple of threads where this was discussed.

Joel

While here, just one small note about "7.4.2.1.1 Building MPlayer":

"However, if you need the XviD codec, you have to specify the WITH_XVID
option in the command line."

Should be:

"However, if you need the XviD codec, you have to specify the WITH_XVID
option on the command line."


Joel

Comment 4 Marc Fonvieille 2004-09-18 08:34:21 UTC

On Sat, Sep 18, 2004 at 09:05:42AM +0200, Joel Dahl wrote:
> While here, just one small note about "7.4.2.1.1 Building MPlayer":
> 
> "However, if you need the XviD codec, you have to specify the WITH_XVID
> option in the command line."
> 
> Should be:
> 
> "However, if you need the XviD codec, you have to specify the WITH_XVID
> option on the command line."
> 
>

Well Please could you use the right place for that?

You added in the audit trail something which has nothing to do with the PR.
And btw I'm not guilty of the whitespaces :))

Please try to use the PR followup in the right way, Thanks.

Marc

On Fri, Sep 17, 2004 at 06:50:11PM +0000, Marc Fonvieille wrote:
> The following reply was made to PR docs/71826; it has been noted by GNATS.
> 
> From: Marc Fonvieille <blackend@FreeBSD.org>
> To: Joel Dahl <joel@automatvapen.se>
> Cc: FreeBSD-gnats-submit@FreeBSD.org
> Subject: Re: docs/71826: [PATCH] Whitespace cleanup
> Date: Fri, 17 Sep 2004 20:42:45 +0200
> 
>  On Fri, Sep 17, 2004 at 08:27:45PM +0200, Joel Dahl wrote:
>  > >Description:
>  > The attached patch fixes some whitespaces in
>  > doc/en_US.ISO8859-1/books/handbook/multimedia/chapter.sgml
>  >
>  
>  This was often discussed in past (consult the freebsd-doc archives).
>  With often the same result: when it's not "mandatory", we leave the
>  things in this state.


If this is the consensual view (I don't recall the discussion), then
please close the PR.

Ceri
-- 
It is not tinfoil, it is my new skin.  I am a robot.

Comment 6 Giorgos Keramidas 2004-09-21 06:54:45 UTC

On 2004-09-20 18:15, Ceri Davies <ceri@submonkey.net> wrote:
> On Fri, Sep 17, 2004 at 06:50:11PM +0000, Marc Fonvieille wrote:
> >  > The attached patch fixes some whitespaces in
> >  > doc/en_US.ISO8859-1/books/handbook/multimedia/chapter.sgml
> >
> >  This was often discussed in past (consult the freebsd-doc archives).
> >  With often the same result: when it's not "mandatory", we leave the
> >  things in this state.
>
> If this is the consensual view (I don't recall the discussion), then
> please close the PR.

Every commit increases the disk space the particular file needs on the CVS
repository server, on all the CVS mirrors, on all the copies of the tree that
users keep privately at their home or work, etc.  Bearing this in mind, I have
to agree with Marc.  Whitespace commits should only be done rarely, if there's
no real problem they might solve (such as aesthetic issues of a particular
output format, wrapping of output documents, or similar).

Yes, please close this PR.  When someone does a few content commits to the
multimedia chapter a whitespace commit can follow.  Fixing spaces just for the
sake of fixing spaces isn't really worth the disk space it will take.

- Giorgos

Comment 7 Ceri Davies 2004-10-01 19:46:47 UTC

State Changed
From-To: open->closed

It was decided that this patch is unwanted.