Bug 72104

Summary: [PATCH] sysutils/munin-node: fix PLIST
Product: Ports & Packages Reporter: Yen-Ming Lee <leeym>
Component: Individual Port(s)Assignee: Yen-Ming Lee <leeym>
Status: Closed FIXED    
Severity: Affects Only Me CC: lupe
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
munin-node-1.0.0.patch none

Description Yen-Ming Lee freebsd_committer freebsd_triage 2004-09-26 17:20:20 UTC 
- remove extra files from PLIST
- add missing file into PLIST
- unbreak this port

Port maintainer (lupe@lupe-christoph.de) is cc'd.

Generated with FreeBSD Port Tools 0.63
Comment 1 Yen-Ming Lee freebsd_committer freebsd_triage 2004-09-26 18:01:40 UTC 
State Changed
From-To: open->feedback

The maintainer is Cc-ed.
Comment 2 Yen-Ming Lee freebsd_committer freebsd_triage 2004-09-26 18:01:43 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->leeym

I will take care of this PR.
Comment 3 Yen-Ming Lee freebsd_committer freebsd_triage 2004-10-13 02:46:19 UTC 
State Changed
From-To: feedback->closed

Committed, thanks.
Comment 4 Lupe Christoph 2004-11-01 11:09:19 UTC 
Hi!

I just noticed this PR when I looked for other PR related to munin
submitted recently.

While you (Yen-Ming Lee) say you CCed me, I never received your mail.
There is at least one error in your patch. It adds
etc/munin/VERSION.node to the plist, which causes it to be removed on
upgrades. If you had researched a little more, you would have found that
PR 64285 undid the same change some time ago. Why are you commiters so
keen on showing a porter how Stoopid(tm) he is?!?

And I have never been notified about the chjange that added this
  BROKEN=		"Broken pkg-plist"

I will review this patch and reissue my upgrade patch for Munin 1.0.3.

Thanks,
Lupe Christoph
-- 
| lupe@lupe-christoph.de       |           http://www.lupe-christoph.de/ |
| "... putting a mail server on the Internet without filtering is like   |
| covering yourself with barbecue sauce and breaking into the Charity    |
| Home for Badgers with Rabies.                            Michael Lucas |
Comment 5 Yen-Ming Lee freebsd_committer freebsd_triage 2004-11-01 17:19:20 UTC 
Your mail server block all mail from Taiwan. That's why you didn't get my mail.

leeym@utopia:[W5]~/.mldonkey/incoming> host -t mx lupe-christoph.de
lupe-christoph.de mail is handled by 100 relay.b-5.de.
lupe-christoph.de mail is handled by 200 www.octogon.de.
leeym@utopia:[W5]~/.mldonkey/incoming> telnet relay.b-5.de 25
Trying 80.148.32.30...
Connected to relay.b-5.de.
Escape character is '^]'.
220-buexe.b-5.de ESMTP Sendmail 8.12.3/8.12.3/b-5/buexe-3.4
220-Mon, 1 Nov 2004 17:56:59 +0100
220-You are utopia.leeym.com(OK)-utopia.leeym.com [211.21.137.52]
220 Spammers, see Figure 1. ("help figure1" or "http://b-5.de/fig1/")
helo leeym
250 buexe.b-5.de Hello utopia.leeym.com [211.21.137.52], pleased to meet you
mail from: <leeym@leeym.com>
550 5.7.0 Mail rejected from 211.21.137.52 - Taiwan blocked by taiwan.blackholes.us - see http://www.blackholes.us/
^]
zh-telnet> q
Connection closed.

BTW, you should not left configuration files after a port is deinstalled.
If you want to install some sample configuration files, install it with a
suffix (says .sample), copy sample to original filename when installing,
and delete it if it's not modified when deinstalling.

You can take /usr/ports/sysutils/bsdsar/pkg-plist as an example.

-- 
Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
Comment 6 Lupe Christoph 2004-11-01 17:56:23 UTC 
On Monday, 2004-11-01 at 17:19:20 +0000, Yen-Ming Lee wrote:
> Your mail server block all mail from Taiwan. That's why you didn't get my mail.

Right. Sigh. Taiwan isn't sending many Spams anyway, so I'll remove
that RBL. For the RBLs, have a look at
  http://www.lupe-christoph.de/rblstats.html
Right now, it has a little glitch. No 1.11., but two 31.10s.

I'm glad you found a way around this block. Didn't you get a bounce when
you sent the mail I didn't get?

> BTW, you should not left configuration files after a port is deinstalled.
> If you want to install some sample configuration files, install it with a
> suffix (says .sample), copy sample to original filename when installing,
> and delete it if it's not modified when deinstalling.

> You can take /usr/ports/sysutils/bsdsar/pkg-plist as an example.

And this applies to munin-node - how?

Thanks,
Lupe Christoph
-- 
| lupe@lupe-christoph.de       |           http://www.lupe-christoph.de/ |
| "... putting a mail server on the Internet without filtering is like   |
| covering yourself with barbecue sauce and breaking into the Charity    |
| Home for Badgers with Rabies.                            Michael Lucas |
Comment 7 Lupe Christoph 2004-11-01 18:54:04 UTC 
On Monday, 2004-11-01 at 18:56:23 +0100, Lupe Christoph wrote:
> On Monday, 2004-11-01 at 17:19:20 +0000, Yen-Ming Lee wrote:

> > BTW, you should not left configuration files after a port is deinstalled.
> > If you want to install some sample configuration files, install it with a
> > suffix (says .sample), copy sample to original filename when installing,
> > and delete it if it's not modified when deinstalling.

> > You can take /usr/ports/sysutils/bsdsar/pkg-plist as an example.

> And this applies to munin-node - how?

Found it. You are referring to /usr/local/etc/munin/munin-node.conf and
my putting a sample there if no file exists. Right, I will see that I
put this in.

Thanks,
Lupe Christoph
-- 
| lupe@lupe-christoph.de       |           http://www.lupe-christoph.de/ |
| "... putting a mail server on the Internet without filtering is like   |
| covering yourself with barbecue sauce and breaking into the Charity    |
| Home for Badgers with Rabies.                            Michael Lucas |