Summary: | [PATCH] devel/subversion: update to 1.1.0 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Cheng-Lung Sung <clsung> | ||||
Component: | Individual Port(s) | Assignee: | Lev A. Serebryakov <lev> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | lev | ||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Cheng-Lung Sung
2004-10-14 06:20:05 UTC
Responsible Changed From-To: freebsd-ports-bugs->lev over to maintainer. PR ports/73135 has a partial update to 1.1.1. Compared to my patch, I think you have a bit of plist breakage (I don't see the *.po files), and you didn't address some breakage caused by the apr-1.0 update (maybe it happened after you submitted this patch). On the other hand, I managed to break the Perl bindings in my patch, but it looks like you addressed whatever Perl changes were needed. Maybe lev can take the best of both our patches. :-) Yes, This pr (patch) is not really suitable for upgrade. I've created two patches a few days ago, http://freebsd.csie.nctu.edu.tw/~clsung/subversion-1.1.0.patch http://freebsd.csie.nctu.edu.tw/~clsung/subversion-1.1.1.patch Though I didn't do a complete test :) Thanks, clsung On Mon, Oct 25, 2004 at 11:45:04AM -0700, Bruce A. Mah wrote: > PR ports/73135 has a partial update to 1.1.1. > > Compared to my patch, I think you have a bit of plist breakage (I don't > see the *.po files), and you didn't address some breakage caused by the > apr-1.0 update (maybe it happened after you submitted this patch). > > On the other hand, I managed to break the Perl bindings in my patch, > but it looks like you addressed whatever Perl changes were needed. > > Maybe lev can take the best of both our patches. :-) On Mon, 2004-10-25 at 17:12, Cheng-Lung Sung wrote: > I've created two patches a few days ago, > http://freebsd.csie.nctu.edu.tw/~clsung/subversion-1.1.0.patch > http://freebsd.csie.nctu.edu.tw/~clsung/subversion-1.1.1.patch > > Though I didn't do a complete test :) Cool! I merged in a few changes from your patch into my patch (I didn't do the apr-config/apu-config detection quite correctly but you did, you also fixed up some pre-existing port problems). The resulting combination of our two patches is at: http://people.freebsd.org/~bmah/pub/subversion.patch I think the major remaining differences are: 1) I updated files/build-outputs.mk.patch whereas you deleted it (note that some form of this patch is required for WITH_SVNSERVE_WRAPPER to work). 2) I added SVN::Fs.3 to MAN3 for the WITH_PERL case. 3) I added a new patch for Makefile.PL.in that tracks its new location (I think this buys us "respect CCFLAGS"). I haven't played with the Perl bindings, but I tested the Python bindings with an earlier version of this patch, as well as mod_dav_svn. Thanks, Bruce. That's Great!!!1
Thank you :)
clsung.
On Mon, Oct 25, 2004 at 09:09:36PM -0700, Bruce A. Mah wrote:
> On Mon, 2004-10-25 at 17:12, Cheng-Lung Sung wrote:
> > I've created two patches a few days ago,
> > http://freebsd.csie.nctu.edu.tw/~clsung/subversion-1.1.0.patch
> > http://freebsd.csie.nctu.edu.tw/~clsung/subversion-1.1.1.patch
> >
> > Though I didn't do a complete test :)
>
> Cool! I merged in a few changes from your patch into my patch (I didn't
> do the apr-config/apu-config detection quite correctly but you did, you
> also fixed up some pre-existing port problems). The resulting
> combination of our two patches is at:
>
> http://people.freebsd.org/~bmah/pub/subversion.patch
>
> I think the major remaining differences are: 1) I updated
> files/build-outputs.mk.patch whereas you deleted it (note that some form
> of this patch is required for WITH_SVNSERVE_WRAPPER to work). 2) I
> added SVN::Fs.3 to MAN3 for the WITH_PERL case. 3) I added a new patch
> for Makefile.PL.in that tracks its new location (I think this buys us
> "respect CCFLAGS").
>
> I haven't played with the Perl bindings, but I tested the Python
> bindings with an earlier version of this patch, as well as mod_dav_svn.
>
> Thanks,
>
> Bruce.
>
State Changed From-To: open->closed closed, per submitter's request. obsoleted by ports/73135. On Tue, 2004-10-26 at 19:29, Cheng-Lung Sung wrote:
> That's Great!!!1
Now we need lev to commit it (or to let one of us do it). :-)
Bruce.
|