Bug 72968

Summary: Broken network support in x{mame,mess} partially failing silently
Product: Ports & Packages Reporter: Christopher Nehren <apeiron>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Christopher Nehren 2004-10-21 18:00:14 UTC
As stated http://www.mail-archive.com/xmame@toybox.twisted.org.uk/msg07256.html,
networking support is currently known to be broken in xmame and xmess. The port
will still attempt to build network support, however, which will fail because
the code is broken. Apparently the port maintainer wants the port to continue
building but without networking support, and without notifying the user. This
silent failure can cause much confusion (it did for me and others, at least).
Therefore, I recommend marking the port as BROKEN rather than partially failing
silently. This way a user isn't led to believe -- under false pretenses -- that
their networking should still be working.

Also take note that the port does not properly disable networking support even
if it's enabled.

How-To-Repeat: Attempt to build recent xmame/xmess with networking support, notice the broken
code.
Comment 1 Miguel Mendez 2004-10-22 08:17:28 UTC
On Thu, 21 Oct 2004 12:54:40 -0400 (EDT)
Christopher Nehren <apeiron@comcast.net> wrote:

Christopher,

It was certainly an omission on my part and I should have added a
pkg-message warning the user about it. The thing is, your condescending
tone was uncalled for. I have more important things to worry about than
having a perfect xmame port (specially considering we've been in ports
freeze until recently) but, since it seems to be so important to you, be
my guest and become the new maintainer. That's all I have to say.

Cheers,
-- 
	Miguel Mendez <flynn@energyhq.es.eu.org>
	http://www.energyhq.es.eu.org
	PGP Key: 0xDC8514F1
	Note: All HTML and non-english mail goes to /dev/null
Comment 2 Christopher Nehren 2004-10-22 15:44:37 UTC
On Fri, 2004-10-22 at 09:17 +0200, Miguel Mendez wrote:
> It was certainly an omission on my part and I should have added a
> pkg-message warning the user about it. The thing is, your condescending
> tone was uncalled for. I have more important things to worry about than
> having a perfect xmame port (specially considering we've been in ports
> freeze until recently) but, since it seems to be so important to you, be
> my guest and become the new maintainer. That's all I have to say.


... eep. The PR was not meant to be condescending or anything else of
the sort. I apologise for that. All that I wanted to accomplish was to
give the people reading the PR an account from my perspective of the
issue with the port. I definitely couldn't do as good a job as you have
with maintaining the port.

-- 
I abhor a system designed for the "user", if that word is a coded
pejorative meaning "stupid and unsophisticated".  -- Ken Thompson
-
Unix is user friendly. However, it isn't idiot friendly.
Comment 3 Miguel Mendez 2004-10-22 20:52:03 UTC
On Fri, 22 Oct 2004 10:44:37 -0400
Christopher Nehren <apeiron@comcast.net> wrote:

Hi,

> ... eep. The PR was not meant to be condescending or anything else of
> the sort. I apologise for that. All that I wanted to accomplish was to
> give the people reading the PR an account from my perspective of the
> issue with the port. I definitely couldn't do as good a job as you
> have with maintaining the port.

Ok, sorry for blowing things out of proportion. This last 2 weeks have
been specially stressing at work. Let's have this patch comitted and, in
two weeks when I have some days off I'll work on fully OPTIONS-ifying
the port. 

Sorry again for the mess. Now time to head to the pub to relax.

-- 
	Miguel Mendez <flynn@energyhq.es.eu.org>
	http://www.energyhq.es.eu.org
	PGP Key: 0xDC8514F1
	Note: All HTML and non-english mail goes to /dev/null
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2004-12-19 17:28:46 UTC
State Changed
From-To: open->closed

Maintainer notes that this has been fixed by a later port update.